Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Taxjar Failing for too many requests #24

Closed
romancristinel opened this issue Jan 12, 2019 · 2 comments
Closed

Taxjar Failing for too many requests #24

romancristinel opened this issue Jan 12, 2019 · 2 comments

Comments

@romancristinel
Copy link

When taxjar service fails with Error code 429 (possibly others) the exception is not handling the data properly:

https://github.com/taxjar/taxjar-php/blob/master/lib/TaxJar.php#L37

There are no error and detail properties, therefore the taxjar-php library throws a weird exception ("Trying to get property 'detail' of non-object")

@ryanreeves-taxjar
Copy link

Thanks @romancristinel for reporting this. We're looking into addressing it in a future version.

@fastdivision
Copy link
Contributor

Our API should now return a valid JSON error response for 429 errors with error and detail attributes included. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants