We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When taxjar service fails with Error code 429 (possibly others) the exception is not handling the data properly:
https://github.com/taxjar/taxjar-php/blob/master/lib/TaxJar.php#L37
There are no error and detail properties, therefore the taxjar-php library throws a weird exception ("Trying to get property 'detail' of non-object")
error
detail
The text was updated successfully, but these errors were encountered:
Thanks @romancristinel for reporting this. We're looking into addressing it in a future version.
Sorry, something went wrong.
Our API should now return a valid JSON error response for 429 errors with error and detail attributes included. Thank you!
No branches or pull requests
When taxjar service fails with Error code 429 (possibly others) the exception is not handling the data properly:
https://github.com/taxjar/taxjar-php/blob/master/lib/TaxJar.php#L37
There are no
error
anddetail
properties, therefore the taxjar-php library throws a weird exception ("Trying to get property 'detail' of non-object")The text was updated successfully, but these errors were encountered: