Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Icon request] Flatpak Apps #1

Closed
28 tasks done
hhawkens opened this issue Aug 15, 2022 · 10 comments
Closed
28 tasks done

[Icon request] Flatpak Apps #1

hhawkens opened this issue Aug 15, 2022 · 10 comments
Labels
enhancement New feature or request

Comments

@hhawkens
Copy link

hhawkens commented Aug 15, 2022

(Fedora 36, Gnome 42, libadwaita)

Some in-app icons seem to be missing (all flatpak):

  • Start page of Mousai
  • Start page of Fragments (small icon)

Icons for apps (all flatpak) :

  • PCSX2
  • PCSX2 Qt (comes bundled with the regular version, I guess)
  • RPCS3
  • Xemu
  • Heroic Games Launcher
  • Dolphin Emulator
  • Retroarch
  • Youp for WhatsApp
  • Brave
  • Parsec
  • JDownloader
  • Junction
  • Mousai
  • Shortwave
  • Jellyfin Media Player
  • Gnome Subtitles
  • Mkv Toolnix GUI
  • Duolingo
  • Godot Engine
  • Freetube
  • Nextcloud Desktop
  • Filezilla
  • Authenticator (Gnome app)
  • PDF Arranger
  • Paper
  • Bottles

PS: Great icon theme overall!

@TaylanTatli
Copy link
Owner

Hi! Thank you. I never used flatpak, is it use the same icon names as non flatpak version? Can you share the name of the icons, so I can start working on them?

@baduhai
Copy link

baduhai commented Aug 16, 2022

Unfortunately, flatpaks don't always have the same icon name as non-flatpaked icons. The flatpak for mpv uses io.mpv.Mpv icon name, for example. The way I've seen other icon packs manage this, is by symlinking to the original icon name with the flatpak icon name.

@hhawkens
Copy link
Author

hhawkens commented Aug 16, 2022

Hi! Thank you. I never used flatpak, is it use the same icon names as non flatpak version? Can you share the name of the icons, so I can start working on them?

I am not sure what the names of these icons are. How can I find out?

@TaylanTatli
Copy link
Owner

Hi! Thank you. I never used flatpak, is it use the same icon names as non flatpak version? Can you share the name of the icons, so I can start working on them?

I am not sure what the names of these icons are. How can I find out?

I will look into it.

@TaylanTatli TaylanTatli changed the title [Icon request] [Icon request] Flatpak Apps Aug 16, 2022
TaylanTatli added a commit that referenced this issue Aug 16, 2022
TaylanTatli added a commit that referenced this issue Aug 16, 2022
TaylanTatli added a commit that referenced this issue Aug 16, 2022
@TaylanTatli
Copy link
Owner

Some in-app icons seem to be missing (all flatpak):
* Start page of Mousai
* Start page of Fragments (small icon)

Can you share screenshot for theese? I installed apps from flatpak and didn't see any problem. Also updated app icons for theese.

TaylanTatli added a commit that referenced this issue Aug 16, 2022
TaylanTatli added a commit that referenced this issue Aug 16, 2022
TaylanTatli added a commit that referenced this issue Aug 16, 2022
TaylanTatli added a commit that referenced this issue Aug 16, 2022
TaylanTatli added a commit that referenced this issue Aug 16, 2022
TaylanTatli added a commit that referenced this issue Aug 16, 2022
@TaylanTatli TaylanTatli added the enhancement New feature or request label Aug 16, 2022
@hhawkens
Copy link
Author

Some in-app icons seem to be missing (all flatpak):

  • Start page of Mousai
  • Start page of Fragments (small icon)

Can you share screenshot for theese? I installed apps from flatpak and didn't see any problem. Also updated app icons for theese.

Sure:

fragments
mousai

@TaylanTatli
Copy link
Owner

TaylanTatli commented Aug 17, 2022

Ekran Görüntüsü - 2022-08-17 17-00-18

@hhawkens This is weird. This theme inherits Adwaita on Gnome and Breeze on KDE. Do you use any of them? I didn't add all the action icons. Also if you use Sevi-Dark, do you have also Sevi?

BTW I added icon for Mousai, it should be ok now.

TaylanTatli added a commit that referenced this issue Aug 17, 2022
TaylanTatli added a commit that referenced this issue Aug 17, 2022
TaylanTatli added a commit that referenced this issue Aug 17, 2022
TaylanTatli added a commit that referenced this issue Aug 17, 2022
TaylanTatli added a commit that referenced this issue Aug 17, 2022
TaylanTatli added a commit that referenced this issue Aug 17, 2022
TaylanTatli added a commit that referenced this issue Aug 17, 2022
TaylanTatli added a commit that referenced this issue Aug 17, 2022
TaylanTatli added a commit that referenced this issue Aug 17, 2022
TaylanTatli added a commit that referenced this issue Aug 17, 2022
TaylanTatli added a commit that referenced this issue Aug 17, 2022
TaylanTatli added a commit that referenced this issue Aug 17, 2022
TaylanTatli added a commit that referenced this issue Aug 17, 2022
TaylanTatli added a commit that referenced this issue Aug 17, 2022
TaylanTatli added a commit that referenced this issue Aug 17, 2022
TaylanTatli added a commit that referenced this issue Aug 17, 2022
TaylanTatli added a commit that referenced this issue Aug 17, 2022
TaylanTatli added a commit that referenced this issue Aug 17, 2022
@TaylanTatli
Copy link
Owner

Hey @hhawkens, I added all the icons you want. Only Fragments' action icons are left.

@hhawkens
Copy link
Author

hhawkens commented Aug 17, 2022

Ekran Görüntüsü - 2022-08-17 17-00-18

@hhawkens This is weird. This theme inherits Adwaita on Gnome and Breeze on KDE. Do you use any of them? I didn't add all the action icons. Also if you use Sevi-Dark, do you have also Sevi?

BTW I added icon for Mousai, it should be ok now.

I use Adwaita dark (shell theme) and I have Sevi and Sevi-dark installed. No idea whats wrong there, but it has to do with the icon theme (not just Sevi, others like Win11-dark do not work either). When I switch to the Adwaita icon theme, it shows the correct icon.

@TaylanTatli
Copy link
Owner

I use Adwaita dark (shell theme) and I have Sevi and Sevi-dark installed. No idea whats wrong there, but it has to do with the icon theme (not just Sevi, others like Win11-dark do not work either). When I switch to the Adwaita icon theme, it shows the correct icon.

Sorry I can't help with this, Flatpak version works as expected on me. Maybe there is something wrong in your configs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants