Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seems like responses with code 400 aren't actually throwing errors when creating an opportunity #36

Closed
rathboma opened this issue May 4, 2017 · 2 comments

Comments

@rathboma
Copy link

rathboma commented May 4, 2017

Make a call to client.create_opportunity with an incorrect opportunity value and you'll see it log a 400 response code but not actually throw an error

client.create_opportunity({
 lead_id: "..",
 value: 100.5, # this is invalid, integers only
 value_period: "monthly",
 status_id: "..."
})

It'll log, but not error throw.

@rathboma rathboma changed the title Seems like responses with code 400 aren't actually throwing errors Seems like responses with code 400 aren't actually throwing errors when creating an opportunity May 4, 2017
@rathboma
Copy link
Author

rathboma commented May 4, 2017

The same is true if you provide an invalid user_id or status_id

@rathboma
Copy link
Author

rathboma commented May 5, 2017

nevermind. I've been coding scala for too long and was assuming named parameters worked the same. My fault

@rathboma rathboma closed this as completed May 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant