Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Faraday 2.x #76

Closed
Roguelazer opened this issue Apr 5, 2023 · 3 comments
Closed

Support Faraday 2.x #76

Roguelazer opened this issue Apr 5, 2023 · 3 comments

Comments

@Roguelazer
Copy link

The gem depends on faraday_middleware, which means that it only works with Faraday 1.x; it would be swell if it supported Faraday 2.x, too.
@Roguelazer Roguelazer mentioned this issue Apr 5, 2023
Closed
@taylorbrooks
Copy link
Owner

Most recent gem version supports Faraday 2.x!

@Roguelazer
Copy link
Author

It looks like you missed one reference.

NameError: uninitialized constant Faraday::Response::Middleware

  class CloseioErrorHandler < Faraday::Response::Middleware

If you look at #77, this moved to Faraday::Middleware in Faraday 2.x...

@taylorbrooks
Copy link
Owner

Doh! Cutting a new version now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

bump closeio to use Faraday 2 instrumentl/closeio
2 participants
@taylorbrooks @Roguelazer