-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature Request: Add support for monitor aspect mapping #16
Comments
This patch actually uses the mapping method I had used previously before mapping to a specific input device. If the monitors are not laid out evenly (ie. portait monitor is centered against the landscape monitor) you end up with an edge case where the wacom starts to freak out. I've started looking at another way to solve this but I'm still hitting the edge case. I'm gone for a week but I'll keep poking at it when I get back. |
What is the mapping method in the code that causes this edge case? - and what does the wacom do in this case? I wasn't aware I was using any mapping in the patch that isn't already used in the code? I didn't actually try with monitors is the set up you mention - but I will do when I get time ... |
I tried setting up the dual monitor layout you suggested (portrait monitor centred against a landscape monitor) - and my aspect mapping changes appeared to work as expected ... I didn't have any weird problems with the wacom ? |
Looks like I mucked up the commands saved with this patch - which I've now fixed and attached as a replacement patch - aspect-mapping-v2.patch.gz |
Closing this issue as the feature is now part of the 3.0.x release series. If any issues arise with the feature please open a new ticket. |
Some of our users prefer to have a tablet area that matches their monitor(s) aspect ratio - i.e. so a circle on the tablet is a circle on screen etc - even when using 2 monitors (which means only half the tablet area is used) - but is also useful when just using one monitor that doesn't match the aspect ratio of the tablet
The (largish) patch below adds this support to the 'Other Settings' tab
A few notes:
wacom-gui current assumes the tablet is in landscape mode which (usually) maps to monitor(s) also in landscape mode. The selectable Aspect Mapping setting are:
However, if the monitor(s) are in a portrait layout (screen width is less than height), then the Aspect Mappings will map to the Right, Middle and Left parts of the tablet area - corresponding to the Top, Middle and Bottom selections (there isn't any support if the tablet is used in portrait mode ...)
To make life a lot easier, the patch also adds support for 'preferences' that are saved and loaded when wacom-gui exits/starts - which saves having to probe the wacom device for settings and attempting to match with what wacom-gui expects.
I've added preferences not only for the "Aspect Mapping" settings, but for the "Screen Area" and "Tablet Orientation" settings - if there are no existing saved settings for these, it will fall-back to probing the device as before. Adding preferences for "Tablet Orientation" is not actually needed for Aspect Mapping support, but as I had added it for "Screen Area", it seemed silly not to :-)
These preferences are saved in a file 'prefs.json' in the same directory as the 'default.sh' script for each tablet type
AFAIK, it all appears to work as expected - however, python is not my first language, so there may well be more pythonesque ways of doing what it does ...
Let me know what you think
The text was updated successfully, but these errors were encountered: