Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mat_VarReadNextInfoIterate takes a long time to read mat-file #196

Closed
GolubevaP opened this issue Dec 13, 2022 · 7 comments
Closed

Mat_VarReadNextInfoIterate takes a long time to read mat-file #196

GolubevaP opened this issue Dec 13, 2022 · 7 comments

Comments

@GolubevaP
Copy link

Reading the header by indexes takes a lot of time (several minutes), moreover, it requires a lot of memory to read it. Although this is only needed to make sure that the file can be opened.
I realized that the problem is in this method (Mat_VarReadNextInfoIterate), in particular, in nested loops. And also this problem met earlier (#157). Will you fix it?

@Ri0n
Copy link
Contributor

Ri0n commented Jan 13, 2023

Hello dear developers.

This PR #197 partially resolves the problem.
But the root of the problem is hidden in usage of H5Iget_name which is extremely slow. I have another patch to resolve it too. Not yet ready for publishing though.

@Ri0n
Copy link
Contributor

Ri0n commented Jan 13, 2023

And there is a PR for avoiding usage of H5Iget_name
https://github.com/Ri0n/matio/pull/1/files

@Ri0n
Copy link
Contributor

Ri0n commented Jan 13, 2023

A PR for H5Iget_name against this repo #198
I'm very worried if I could break anything with this change. So I hope developers can propose appropriate tests and teest it on their own.

@tbeu
Copy link
Owner

tbeu commented Jan 14, 2023

@Ri0n Thanks for both your PRs. They are very appreciated.

@tbeu
Copy link
Owner

tbeu commented Jan 24, 2023

@GolubevaP Which MAT-file version did you use? Do you have any MAT-file to share? Thanks.

@tbeu
Copy link
Owner

tbeu commented Oct 21, 2023

@GolubevaP Which MAT-file version did you use? Do you have any MAT-file to share? Thanks.

@GolubevaP Since #157 is fixed and @Ri0n contributed his fixes, can you please test again. Thanks!

@tbeu
Copy link
Owner

tbeu commented Jan 6, 2024

Closing after @GolubevaP not responding.

@tbeu tbeu closed this as completed Jan 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants