-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PBC Question #1
Comments
The issue present in grimme-lab/xtb#257 should be resolved in this implementation, but I'm currently not implementing GFN0-xTB here. I tested the implementation quite thoroughly and are pretty confident that I got it right. What is missing is some quality of life stuff, like a release, full documentation and binary packages. If you feel brave enough, you can try to compile the library in DFTB+ (see dftbplus/dftbplus#792) or build the Python extension module to use it in ASE. Feedback for both is more than welcome. |
I have been able to run tblite from the command line but I am stuck when trying to build the extension module for python. I tried pip and meson both result with this error when trying to run a sp |
To build Python extension modules with MKL the normal MKL libraries are not usable, instead the real time variant has to linked with |
To close the loop on this, I tested the python extension module with ASE. Not a ton of feedback — worked as advertised once I got it installed. I tested PBCs with translations and rotations and everything I saw was consistent. I did not test systems with halogen bonding. Any plans to include GFN0? (I ask because GFN1 and GFN2 have convergence issues for some of systems we are interested in) |
Thanks for the feedback, much appreciated.
Currently not, GFN0-xTB is still a half-backed parametrization with known issues. Maybe I will provide the possibility to construct something like GFN0-xTB, but I think the way forward is to provide the possibility for creating tailored parametrizations with |
I see. From our perspective, GFN0 isn't perfect but it is fast and always gives an answer which are both good for delta learning. I also think creating tailored parameterization would be very interesting. Feel free to close |
Hi Sebastian,
This looks like a really cool project. I have been following the PBC discussions on the main xTB repo grimme-lab/xtb#491, grimme-lab/xtb#257, is the updated pbc method reference in grimme-lab/xtb#491 currently implemented in this repo or is that for a future commit? Also, does highly experimental mean it is worth trying to run some calculations or it best to wait?
Thanks!
-Brandon
The text was updated successfully, but these errors were encountered: