-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exogenous Features #4
Comments
For the optimize issue: Everything that would normally be passed to fit that is being passed to optimize or ensemble needs to be wrapped in a list. So exogenous_estimator and exogenous needs list brackets and it should work. Your second issue is using the normal fit method so it is fine to pass non-lists. And if you do pass lists then it will use those as 'Generator' variables, see the README and ctrl f to learn some more about those. BUT you are passing list of lists which won't work for fit. Just be careful when you are using standard fit vs optimize/ensemble methods as the variable requirements change. Don't see anything that is working incorrectly here. |
I will say (after looking more into this more) there is a lot of instability with using exogenous and optimize primarily due to the index of the exogenous being referenced to create test sets. I'll try to address this in the next push but for now just be very careful when passing exogenous stuff. I would make sure everything is a dataframe and when predicting the future_exogenous dataframe index lines up with the one passed to fit/optimize/ensemble. |
Thanks! Great library by the way! Time Serie Decomposition is the key to build a great forcasting model, ThymeBoost is very ingenious and powerfull! |
Hi,
I don't know if it's a bug, but adding exogenous features seems not working:
The text was updated successfully, but these errors were encountered: