Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't run other packages with core using Deno #287

Closed
tbranyen opened this issue Nov 21, 2022 · 2 comments
Closed

Can't run other packages with core using Deno #287

tbranyen opened this issue Nov 21, 2022 · 2 comments

Comments

@tbranyen
Copy link
Owner

When using Deno with core and some other package, the subsequent package is unable to find core. Currently core registers itself under globalThis[Symbol.for('diffHTML')] and then related packages hook into core by reading this value. This means core must always be loaded first. This works great in Node and the browser, but fails to work in Deno.

image
@tbranyen
Copy link
Owner Author

tbranyen commented Dec 4, 2022

Looks like this should "just work":

image

@tbranyen
Copy link
Owner Author

tbranyen commented Dec 4, 2022

Nevermind, tested again and it works as expected. Not sure how I triggered the error before:

image

image

@tbranyen tbranyen closed this as completed Dec 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tbranyen