Skip to content
This repository has been archived by the owner on Sep 13, 2018. It is now read-only.

Support for Refaster #65

Closed
jbduncan opened this issue Apr 1, 2018 · 5 comments
Closed

Support for Refaster #65

jbduncan opened this issue Apr 1, 2018 · 5 comments

Comments

@jbduncan
Copy link

jbduncan commented Apr 1, 2018

Recently, I've been looking into getting Refaster, part of error-prone, set up for a currently private Gradle project, but I've not been able to find any docs or code references to Refaster in gradle-errorprone-plugin, so I've been trying to hack together a solution with limited success so far...

If there is support in gradle-errorprone-plugin for Refaster, then I'd be very grateful for some pointers! But if there's no support, would it be considered as a possible new feature?

@tbroyer
Copy link
Owner

tbroyer commented Apr 2, 2018

There's currently no support for Refaster, but yes this is something I've been thinking about.

More accurately, I've been thinking about "patching" (for regular bug checks), but would need guidance from Gradle devs to get the design right.

@jbduncan
Copy link
Author

jbduncan commented Apr 2, 2018

Sounds good to me!

If you do manage to get something working in the future, then great! But if not, then that's fine too; I do not want to put you under any pressure. :)

@jbduncan
Copy link
Author

jbduncan commented May 2, 2018

I recently open sourced the project I mentioned above (licensed Apache 2.0), where I made efforts to turn Refaster into a Gradle buildSrc plugin. I'm sharing a link to the plugin with you in the hope that it helps. https://github.com/jbduncan/jupiter-collection-testers/tree/master/buildSrc

@tbroyer
Copy link
Owner

tbroyer commented Aug 30, 2018

I'm deprecating this plugin in favor of https://github.com/tbroyer/gradle-errorprone-javacplugin-plugin (repos and plugins will soon be renamed so the new one replaces this one).
I also think it would work better as a separate plugin (patching could be part of the ErrorProne plugin, probably not compilation of refaster templates though), so I'm closing the issue here and not port it over to the new project.

@tbroyer tbroyer closed this as completed Aug 30, 2018
@jbduncan
Copy link
Author

I also think it would work better as a separate plugin (patching could be part of the ErrorProne plugin, probably not compilation of refaster templates though), so I'm closing the issue here and not port it over to the new project.

Oh okay. Kind of sad to hear, but cheers for considering this issue though! I'll continue working on my buildSrc-based plugin, and if I grow confident I may decide to split it out into its own open source project. So stay tuned if this is of interest to you. :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants