Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should we just leave type=java-source processing to dependency:unpack? #29

Closed
tbroyer opened this issue Jul 11, 2015 · 1 comment
Closed

Should we just leave type=java-source processing to dependency:unpack? #29

tbroyer opened this issue Jul 11, 2015 · 1 comment

Comments

@tbroyer
Copy link
Owner

tbroyer commented Jul 11, 2015

The way we process <type>java-source</type> in gwt:import-sources could be replaced with dependency:unpack or dependency:unpack-dependencies, and a declared <resource> or possibly build-helper:add-resource (and similarly for import-test-resources).

In retrospect, using <classifier>sources</classifier> is OK most of the time, and <type>java-source</type> has only few advantages, and some drawbacks (more I/O).
@tbroyer
Copy link
Owner Author

tbroyer commented Jul 28, 2015

Done in ee08636

@tbroyer tbroyer closed this as completed Jul 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tbroyer