Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normative: make String.prototype.matchAll throw for non-global regular expressions #1716

Merged

Conversation

@mathiasbynens
Copy link
Member

commented Oct 2, 2019

Per October 2 2019 TC39 meeting consensus.

Tracking issues

@ljharb ljharb requested review from msaboff and tc39/ecma262-editors Oct 2, 2019
@ljharb
ljharb approved these changes Oct 2, 2019
ljharb added a commit to ljharb/test262 that referenced this pull request Oct 3, 2019
ljharb added a commit to ljharb/test262 that referenced this pull request Oct 3, 2019
leobalter added a commit to tc39/test262 that referenced this pull request Oct 3, 2019
@ljharb ljharb added has tests and removed needs tests labels Oct 3, 2019
@ljharb

This comment has been minimized.

Copy link
Member

commented Oct 3, 2019

Tests are merged: tc39/test262#2389

@ljharb

This comment has been minimized.

Copy link
Member

commented Oct 3, 2019

Confirmed in person with @msaboff that the PR is good to go.

…lar expressions (#1716)
@ljharb ljharb force-pushed the mathiasbynens:throw-on-non-global-regexp-in-matchAll branch from e93524c to 1d0fe7c Oct 3, 2019
@ljharb ljharb merged commit 1d0fe7c into tc39:master Oct 3, 2019
1 check passed
1 check passed
netlify/ecma262-snapshots/deploy-preview Deploy preview ready!
Details
mathiasbynens added a commit to tc39/proposal-string-replaceall that referenced this pull request Oct 3, 2019
ljharb added a commit to es-shims/String.prototype.matchAll that referenced this pull request Oct 3, 2019
jmdyck added a commit to jmdyck/ecma262 that referenced this pull request Oct 5, 2019
jmdyck added a commit to jmdyck/ecma262 that referenced this pull request Oct 5, 2019
ljharb added a commit to jmdyck/ecma262 that referenced this pull request Oct 6, 2019
 - Add a subscript R: Since _intValue_ is to be treated as a mathematical value, we should be comparing it to a mathematical zero.
 - Reinstate 'sec-static-semantics-elisionwidth' as an oldid; tc39#1124 removed the element-id 'sec-static-semantics-elisionwidth'
 - Reinstate 'sec-synchronizeeventset' as an oldid; tc39#1692 removed the element-id 'sec-synchronizeeventset'.
 - Reference 'ExportFromClause' from Annex A; tc39#1174 introduced the nonterminal 'ExportFromClause', but didn't reference it from Annex A.
 - Put asterisks around 'true' (from tc39#1716)
 - Fix typo "_eventRecords_" -> "_eventsRecord_" (from tc39#1692)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.