Skip to content

Conversation

sidshank
Copy link
Contributor

This pull request enables CodeQL analysis of code using TypeScript 5.6 features. Notably, the use of arbitrary import/export specifiers is now supported. Ref 1, 2

Release announcement here: https://devblogs.microsoft.com/typescript/announcing-typescript-5-6/

Pull Request checklist

All query authors

Internal query authors only

  • Autofixes generated based on these changes are valid, only needed if this PR makes significant changes to .ql, .qll, or .qhelp files. See the documentation (internal access required).
  • Changes are validated at scale (internal access required).

This commit enables support for arbitrary names for identifier and namespace imports and exports
Adds test for arbitrary identifiers used in imports and exports
Copy link
Contributor

@erik-krogh erik-krogh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Evaluations are looking good.

LGTM 👍

@sidshank sidshank merged commit 983eb19 into main Sep 11, 2024
12 checks passed
@sidshank sidshank deleted the sidshank/ts-5.6 branch September 11, 2024 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants