Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow comments in lists #21

Closed
arv opened this issue Jan 22, 2015 · 3 comments
Closed

Allow comments in lists #21

arv opened this issue Jan 22, 2015 · 3 comments

Comments

@arv
Copy link
Member

arv commented Jan 22, 2015

I had the following md:

1. abc
  <!-- comment -->
  1. def

And I get the error message:

Possibly unhandled SyntaxError. Expected "  " or [0-9] but "<" found.
@bterlson
Copy link
Member

I could probably parse this out on my end before passing to emd but emd also does not like blank lines:

1. a

2. b

will fail. Probably by design, too. So I could be smarter and remove whitespace around comments too but that seems prone to failure and more difficult than simply handling html comments in the emd grammar (which, afaict, shouldn't be too difficult).

@domenic
Copy link
Member

domenic commented Jan 22, 2015

Yep, agreed this should be handled by EMD.

We could also allow dedicated comment syntax, e.g. //.

@bterlson
Copy link
Member

I think we need to support html comments at a minimum. I'm not opposed to a comment shorthand but I'm not sure it's necessary either :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants