Skip to content
This repository has been archived by the owner on Jan 25, 2022. It is now read-only.

Add "nu" as RelevantExtensionKeys #99

Merged
merged 1 commit into from
Dec 19, 2018
Merged

Add "nu" as RelevantExtensionKeys #99

merged 1 commit into from
Dec 19, 2018

Conversation

FrankYFTang
Copy link
Contributor

@zbraniecki zbraniecki self-requested a review December 19, 2018 01:49
Copy link
Member

@littledan littledan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this patch. Merging per previous consensus.

@littledan littledan merged commit b1702cc into tc39:master Dec 19, 2018
@anba
Copy link
Contributor

anba commented Dec 19, 2018

  • Does UTS 35 explicitly mention "nu" for relative time formatting or is it implicitly used, cf. 12.3.3 Internal slots:

[...] and implicitly "nu" for the numbering system of the number format used for numbers within the date format.

  • Shouldn't Intl.RelativeTimeFormat.prototype.resolvedOptions be updated to reflect the numbering system option in the output object?

@FrankYFTang
Copy link
Contributor Author

  • Does UTS 35 explicitly mention "nu" for relative time formatting or is it implicitly used, cf. 12.3.3 Internal slots:

[...] and implicitly "nu" for the numbering system of the number format used for numbers within the date format.

Good question. Probably I should change the wording from
"Unicode Technical Standard 35 describes one locale extension key that is relevant to relative time formatting, "nu" for numbering system."
to
"Unicode Technical Standard 35 implicitly describes one locale extension key that is relevant to relative time formatting, "nu" for numbering system."
But where is it in the UTS35 which "describes three locale extension keys that are relevant to date and time formatting, "ca" for calendar, "tz" for time zone, "hc" for hour cycle" ? I have hard time to figure out WHERE that is in UTS35 so I can check is "nu" there or not.

@FrankYFTang
Copy link
Contributor Author

  • Shouldn't Intl.RelativeTimeFormat.prototype.resolvedOptions be updated to reflect the numbering system option in the output object?

Make sense, I will follow up with a PR for both issues above.

brn pushed a commit to brn/v8 that referenced this pull request Jan 8, 2019
Sync with latest Intl.RelativeTimeFormat spec.
See tc39/proposal-intl-relative-time#99
See tc39/proposal-intl-relative-time#100

Bug: v8:8613
Change-Id: Icc5bb73ecf65e979abc23cc430259584a7bf4b48
Reviewed-on: https://chromium-review.googlesource.com/c/1385930
Commit-Queue: Frank Tang <ftang@chromium.org>
Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org>
Cr-Commit-Position: refs/heads/master@{#58607}
@FrankYFTang FrankYFTang deleted the addNu branch March 8, 2019 00:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants