Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editorial: _escapedList_ mixes code units and code points #68

Closed
michaelficarra opened this issue Mar 23, 2024 · 2 comments
Closed

editorial: _escapedList_ mixes code units and code points #68

michaelficarra opened this issue Mar 23, 2024 · 2 comments

Comments

@michaelficarra
Copy link
Member

It'd probably be best to create a string through repeated string-concatenations and call UTF16EncodeCodePoint directly.

@ljharb
Copy link
Member

ljharb commented Mar 23, 2024

Good catch.

Your suggestion tho seems more complex than either converting the code units into code points while adding them, for example.

@ljharb
Copy link
Member

ljharb commented Mar 25, 2024

I think that this is fixed by #67. Will reopen if not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants