Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ToTemporalTime variant that maps undefined to midnight? #2222

Closed
Ms2ger opened this issue May 24, 2022 · 0 comments
Closed

ToTemporalTime variant that maps undefined to midnight? #2222

Ms2ger opened this issue May 24, 2022 · 0 comments
Assignees
@ptomato
Labels
editorial spec-text Specification text involved
Milestone
Stage 4

Comments

@Ms2ger
Copy link
Collaborator

Ms2ger commented May 24, 2022

Could be used at least in Temporal.PlainDate.prototype.toPlainDateTime, Temporal.PlainDate.prototype.toPlainDateTime
@Ms2ger Ms2ger changed the title ToTemporalTime variant that maps undefined to midnight ToTemporalTime variant that maps undefined to midnight? May 24, 2022
@ptomato ptomato added the spec-text Specification text involved label Dec 8, 2022
@ptomato ptomato added this to the Stage 4 milestone Dec 8, 2022
@ptomato ptomato self-assigned this Mar 26, 2024
ptomato added a commit that referenced this issue Mar 26, 2024
@ptomato
Editorial: Factor out ToTemporalTimeOrMidnight
78e090d 
It's a pattern that repeats in a few places, converting a value to
Temporal.PlainTime but treating undefined as midnight. Factor out the
repeated steps into a new AO ToTemporalTimeOrMidnight.

Closes: #2222
@Ms2ger Ms2ger closed this as completed in d5c10e5 Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ptomato ptomato

Labels
editorial spec-text Specification text involved
Projects
None yet
Milestone
Stage 4
Development

No branches or pull requests
2 participants
@Ms2ger @ptomato