Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use fs to import JSON #351

Merged
merged 1 commit into from Feb 13, 2020
Merged

Use fs to import JSON #351

merged 1 commit into from Feb 13, 2020

Conversation

ptomato
Copy link
Collaborator

@ptomato ptomato commented Feb 12, 2020

Importing JSON doesn't work natively.

Un-pin the version of node.

Importing JSON doesn't work natively.

Un-pin the version of node.
@codecov
Copy link

codecov bot commented Feb 12, 2020

Codecov Report

Merging #351 into main will increase coverage by 0.61%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #351      +/-   ##
==========================================
+ Coverage   83.39%   84.01%   +0.61%     
==========================================
  Files          17       17              
  Lines        3415     3415              
  Branches      403      384      -19     
==========================================
+ Hits         2848     2869      +21     
+ Misses        536      517      -19     
+ Partials       31       29       -2
Impacted Files Coverage Δ
polyfill/lib/ecmascript.mjs 93% <0%> (+0.1%) ⬆️
polyfill/lib/timezone.mjs 87.2% <0%> (+0.58%) ⬆️
polyfill/lib/absolute.mjs 88.38% <0%> (+0.64%) ⬆️
polyfill/lib/time.mjs 74.77% <0%> (+0.91%) ⬆️
polyfill/lib/datetime.mjs 81.7% <0%> (+1.21%) ⬆️
polyfill/lib/slots.mjs 89.09% <0%> (+1.81%) ⬆️
polyfill/lib/yearmonth.mjs 77.18% <0%> (+2.01%) ⬆️
polyfill/lib/monthday.mjs 81.2% <0%> (+2.01%) ⬆️
polyfill/lib/date.mjs 72.04% <0%> (+2.48%) ⬆️
polyfill/lib/now.mjs 100% <0%> (+3.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6dd3e7d...c1a7d0c. Read the comment docs.

@ptomato ptomato merged commit 2a466c1 into main Feb 13, 2020
@ptomato ptomato deleted the fix-json-import branch February 13, 2020 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants