Duration fixes #807
Merged
Duration fixes #807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptomato
requested review from
Ms2ger,
justingrant,
pipobscure,
jasonwilliams,
sffc,
gibson042 and
ryzokuken
Codecov Report
@@ Coverage Diff @@
## main #807 +/- ##
=======================================
Coverage 92.24% 92.25%
=======================================
Files 17 17
Lines 4797 4800 +3
Branches 750 754 +4
=======================================
+ Hits 4425 4428 +3
Misses 370 370
Partials 2 2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
gibson042
reviewed
Aug 8, 2020
ryzokuken
approved these changes
Aug 10, 2020
There was a problem hiding this comment.
Thanks for this PR. LGTM with @gibson042's comments addressed.
These are not allowed according to ISO 8601, nor according to our grammar in the spec, but we inadvertently accepted them and even tested for them in the regex tests.
This was already the case in all of the types except Temporal.Duration. Add tests to make sure it stays that way.
Co-authored-by: Richard Gibson <richard.gibson@gmail.com>
ptomato
force-pushed
the
duration-fixes
branch
from
46ce1cb
to
2150634
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor bugs that I have run into while working on negative durations.