Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull in test262 tests #4

Open
bakkot opened this issue Jan 10, 2017 · 6 comments
Open

Pull in test262 tests #4

bakkot opened this issue Jan 10, 2017 · 6 comments

Comments

@bakkot
Copy link
Collaborator

bakkot commented Jan 10, 2017

Now that the frontmatter in test262 is more informative, we can distinguish between passing and failing parser tests by looking at phase.

@bakkot
Copy link
Collaborator Author

bakkot commented Jul 1, 2017

This could be done as a build step, to avoid duplication between projects.

@bakkot
Copy link
Collaborator Author

bakkot commented Jul 2, 2017

@jugglinmike, moving discussion here from the shift-parser-js issue.

This repo is now distributed as an npm package. I think if the main test262 tests were included as a build step, they wouldn't appear in this repo (except the script to download and sort them), but they would appear in the npm distribution. That would make it relatively useable for downstream projects without duplication.

@jugglinmike
Copy link
Contributor

Including the tests via a build step would address the duplication problem, but
it would also introduce a new gate for consumers. They could only update their
tests when this project released a new version. We could pull the tests in from
master via a "post-install" step, but then consumers would be silently
updated for each installation.

@littledan
Copy link
Member

Great to hear your concern for consumers here, @jugglinmike !

@jugglinmike
Copy link
Contributor

Hopefully that's not too out-of-character for me :)

@RReverser
Copy link

Maybe only provide a build or test runner tool as part of this repo and then consumers can point it to any folder (e.g. git submodule to the actual test262) they want?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants