Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Atomics.waitAsync testing plan #2511

Closed
91 tasks done
rwaldron opened this issue Feb 25, 2020 · 1 comment
Closed
91 tasks done

Atomics.waitAsync testing plan #2511

rwaldron opened this issue Feb 25, 2020 · 1 comment
Assignees

Comments

@rwaldron
Copy link
Contributor

rwaldron commented Feb 25, 2020

Atomics.waitAsync

https://tc39.es/proposal-atomics-wait-async/

(All relevant tests must be completed for TypedArray and BigInt)

features.txt

  • Atomics.waitAsync

waitAsync

  • esid: sec-atomics.waitasync
  • Check Name
    • test/built-ins/Atomics/waitAsync/name.js
  • Check length
    • test/built-ins/Atomics/waitAsync/length.js
  • Check descriptor
    • test/built-ins/Atomics/waitAsync/descriptor.js

Atomics.waitAsync(typedArray, index, value, timeout)

  1. Return DoWait(async, typedArray, index, value, timeout).
    • returns a Promise that is resolved when the calling agent is notified
    • returns a Promise when the sleep times out

DoWait ( mode, typedArray, index, value, timeout )

  • 1. Let buffer be ? ValidateSharedIntegerTypedArray(typedArray, true)

  • 2. Let i be ? ValidateAtomicAccess(typedArray, index).

    • Test for abrupt return if ValidateAtomicAccess throws an error
    • ValidateAtomicAccess: (https://tc39.es/ecma262/#sec-validateatomicaccess)
      • Let accessIndex be ? ToIndex(requestIndex)
        • abrupt return if ToIndex throws an error
          • If value is undefined, let index be 0 and return index
          • If integerIndex < 0, throw a RangeError exception.
          • Let index be ! ToLength(integerIndex).
          • If ! SameValue(integerIndex, index) is false, throw a RangeError exception.
      • If accessIndex ≥ length, throw a RangeError exception.
  • 3. If arrayTypeName is "BigInt64Array", let v be ? ToBigInt64(value).

    • Test for abrupt return if ToBigInt throws an error
    • Let n be ? ToBigInt(argument).
      • TODO: drill down into ToBigInt
      • TODO: drill down into ToPrimitive
    • Let int64bit be n modulo 2 ** 64.
    • Return int64bit.
  • 4. Otherwise, let v be ? ToInt32(value).

    • Test for abrupt return if ToInt32 throws an error
    • Let number be ? ToNumber(argument)
      • ToNumber: (superficial cases only)
        • ToNumber(Symbol) --> Throw a TypeError exception.
        • abrupt return if ToNumber throws an error
      • Let int be the Number value that is the same sign as number and whose magnitude is floor(abs(number)).
      • Let int32bit be int modulo 2 ** 32.
      • If int32bit ≥ 2 ** 31, return int32bit - 2 ** 32; otherwise return int32bit.
  • 5. Let q be ? ToNumber(timeout)

    • Test for abrupt return if ToNumber throws an error
    • Let number be ? ToNumber(argument)
      • ToNumber: (superficial cases only)
        • ToNumber(Symbol) --> Throw a TypeError exception.
        • abrupt return if ToNumber throws an error
  • 6. If q is NaN, let t be +∞, else let t be max(q, 0)

    • confirm that passing a negative timeout translates to 0ms
    • confirm that passing NaN as a timeout translate to +infinity
  • 7. If mode is sync, then

    • Let B be AgentCanSuspend().
    • If B is false, throw a TypeError exception.
    • TODO: Identify a way for hosts specify the value of [[CanBlock]]
  • 8. Let block be buffer.[[ArrayBufferData]]. NOT DIRECTLY OBSERVABLE

  • 9. Let offset be typedArray.[[ByteOffset]]. NOT DIRECTLY OBSERVABLE

  • 10. Let indexedPosition be (i × 4) + offset. NOT DIRECTLY OBSERVABLE

  • 11. Let WL be GetWaiterList(block, indexedPosition).

  • 12. Let promiseCapability be undefined. NOT DIRECTLY OBSERVABLE

  • 13. If mode is async, then

    • Let promiseCapability be ! NewPromiseCapability(%Promise%).
  • 14. Perform EnterCriticalSection(WL).

    • EnterCriticalSection:
      • Wait until no agent is in the critical section for WL, then enter the critical section for WL (without allowing any other agent to enter).
  • 15. Let w be ! AtomicLoad(typedArray, i). NOT DIRECTLY OBSERVABLE

  • 16. If v is not equal to w, then

    • a. Perform LeaveCriticalSection(WL).
    • b. If mode is sync, then
      • Return the String "not-equal".
    • c. Perform ! Call(capability.[[Resolve]], undefined, « "not-equal" »).
    • Return promiseCapability.[[Promise]].
  • 17. Let W be AgentSignifier() NOT DIRECTLY OBSERVABLE

  • 18. Let waiterRecord be a new Waiter Record { [[AgentSignifier]]: W, [[PromiseCapability]]: promiseCapability, [[Timeout]]: t, [[Result]]: "ok" }.

    • TODO
  • 19. Perform AddWaiter(WL, waiterRecord).

  • 20. If mode is sync, then

  • 21. Perform LeaveCriticalSection(WL). NOT DIRECTLY OBSERVABLE

  • 22. If mode is sync, then

    • Return waiterRecord.[[Result]].
  • 23. Return promiseCapability.[[Promise]].

@rwaldron rwaldron self-assigned this Feb 25, 2020
@leobalter
Copy link
Member

leobalter commented Jul 9, 2020

@rwaldron I believe the status here has changed, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants