Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove set.variants #49

Closed
Tracked by #41
Aviortheking opened this issue Aug 12, 2021 · 1 comment
Closed
Tracked by #41

Remove set.variants #49

Aviortheking opened this issue Aug 12, 2021 · 1 comment
Assignees
@Aviortheking
Labels
enhancement New feature or request
Milestone
3.0

Comments

@Aviortheking
Copy link
Member

Aviortheking commented Aug 12, 2021 •
edited
Loading

The goal of set.variants was to know if there was cards available in a variant in the set.

This is now better expressed by using the set.cardCount and can be removed from the API

note: deprecate it in the SDKs beforehand
@Aviortheking Aviortheking added enhancement New feature or request project/compiler labels Aug 12, 2021
@Aviortheking Aviortheking added this to the 3.0 milestone Aug 12, 2021
@Aviortheking Aviortheking mentioned this issue Aug 12, 2021
Closed
4 tasks
@Aviortheking
Copy link
Member Author

see #45

@Aviortheking Aviortheking self-assigned this Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Aviortheking Aviortheking

Labels
enhancement New feature or request
Projects
TCGdex Iterative development
Status: Done
Milestone
3.0
Development

No branches or pull requests
1 participant
@Aviortheking