Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not display login button when login is disabled or add an option to hide it #361

Closed
haidaraM opened this issue Aug 17, 2020 · 3 comments
Labels
backend Need a backend update enhancement New feature or request good first issue Good for newcomers login Login & Acls on AKHQ

Comments

@haidaraM
Copy link
Contributor

Hello. First of all, thank you for your work on AKHQ :-)

We are using an AWS ALB in front of AKHQ. The ALB is responsible for authentication with Cognito. We use a dedicated default group in AKHQ.
In our case, the login button in the UI is then useless since no authentication is done inside AKHQ. I'm wondering if there is way to completely disable/hide the login button is that case ? We already disabled the login :

micronaut:
  security:
    enabled: true
    endpoints:
      login:
        enabled: false
      logout:
        enabled: false

I can work on implementing this feature if needed :-). Just need to know where to start

@tchiotludo
Copy link
Owner

Not really sure like that but I think mostly all the work is done here :
https://github.com/tchiotludo/akhq/blob/dev/src/main/java/org/akhq/controllers/AkhqController.java#L63

Maybe if the LoginController is not enabled, you return false on this part.
Just a quick though to help you to start, but not really sure 😄

(test only with the new ui on dev branch)

Tell me if you need more help :)

@tchiotludo tchiotludo added backend Need a backend update enhancement New feature or request login Login & Acls on AKHQ labels Aug 17, 2020
@jniebuhr
Copy link
Contributor

@haidaraM you can take a look at what i'm doing in #342. I'm already changing the login form based on the API response. You could do the same for the header.

@tchiotludo tchiotludo added the good first issue Good for newcomers label Sep 30, 2020
@timtebeek
Copy link
Contributor

@haidaraM have you tried 0.18.0? The login button does not show for me in similar circumstances. Wondering if this issue can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Need a backend update enhancement New feature or request good first issue Good for newcomers login Login & Acls on AKHQ
Projects
Status: Done
Development

No branches or pull requests

4 participants