Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

You can drop json2.js #3

Closed
andrewschaaf opened this issue Mar 5, 2013 · 3 comments
Closed

You can drop json2.js #3

andrewschaaf opened this issue Mar 5, 2013 · 3 comments

Comments

@andrewschaaf
Copy link
Contributor

UIWebView's JavaScript engine's stdlib includes JSON.stringify.

NSString *html = @"<html><head><script type=\"text/javascript\">alert(JSON.stringify({x:'\"'}));</script></head><body></body></html>";
NSURL *url = [NSURL URLWithString:@"http://localhost/"];
[self.webView loadHTMLString:html baseURL:url];
@tcoulter
Copy link
Owner

tcoulter commented Mar 5, 2013

Arguably true. I was prepping for the rare case of running your JS app on a non-iOS device using an older browser, where (somehow) the Jockey code might get executed. I'm not against taking it out however.

@andrewschaaf
Copy link
Contributor Author

Low cognitive load and cleanly-cut abstraction layers help project become used. json2.js adds a little load and its off-topic-ness is a yellow flag.

(Not trying to be rude here, just unfiltered)

@tcoulter
Copy link
Owner

tcoulter commented Mar 5, 2013

Nope, good point. I'll take it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@andrewschaaf @tcoulter