Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vertices being referenced before having been emitted #14

Open
Strum355 opened this issue Mar 24, 2022 · 5 comments
Open

Vertices being referenced before having been emitted #14

Strum355 opened this issue Mar 24, 2022 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@Strum355
Copy link

From the spec:

a vertex needs to be emitted before it can be referenced in an edge.

We discovered lsif-dotnet violates this constraint in its output, which caused LSIF files to be rejected by Sourcegraph

Screenshot of rejection from Sourcegraph:

image

Extract from the malformed LSIF file:

image

@tcz717
Copy link
Owner

tcz717 commented Mar 24, 2022

Hi @Strum355, thanks for submitting the issue. It looks like caused by the new parallel indexer. Did you tried using the legacy mode?(by adding -l parameter) If not, can you do that to validate?

@Strum355
Copy link
Author

Legacy mode was successful yes 🙂

@tcz717
Copy link
Owner

tcz717 commented Mar 24, 2022

Legacy mode was successful yes 🙂

Ok, I will investigate, and before fixing, revert to using the legacy indexer.

@tcz717 tcz717 added the bug Something isn't working label Apr 6, 2022
@tcz717
Copy link
Owner

tcz717 commented Apr 6, 2022

@shuli106

@tcz717
Copy link
Owner

tcz717 commented Apr 7, 2022

Hi @shuli106 , was your malformed lsif file dumped from https://github.com/Alekaei/Commands? I tried to repro it in my local but didn't see the issue
dump.lsif

Commend:

dotnet restore
lsif-dotnet.exe -p 4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants