Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data.table frollmax on descending #25

Open
tdhock opened this issue Jan 29, 2024 · 7 comments
Open

data.table frollmax on descending #25

tdhock opened this issue Jan 29, 2024 · 7 comments

Comments

@tdhock
Copy link
Owner

tdhock commented Jan 29, 2024

@DorisAmoakohene please translate Rdatatable/data.table#5923 to atime and post results here.

@DorisAmoakohene
Copy link
Collaborator

this is the result after I use atime using this code

result.frollmax <- atime::atime(
  
  N = 10^seq(1,3),
  setup = {
    set.seed(123)
    atime <- function(N, k, func) {
      x = func(N)
      y.data.table = data.table::frollmax(x, k)
      
    }
  },
  seconds.limit = 2,
  expr.list = list(
    normal = quote(atime(N, 10^seq(1,3), rnorm)),
    equalto0 = quote(atime(N, 10^seq(1,3), function(N) {rep(0, N)})),
    ascending = quote(atime(N, 10^seq(1,3), function(N) {seq(0, length.out=N)})),
    descending = quote(atime(N, 10^seq(1,3), function(N) {seq(0, by=-1, length.out=N)}))
  )
)

imageee)

@tdhock
Copy link
Owner Author

tdhock commented Jan 29, 2024

great start, please increase N so we may see more differences.

@DorisAmoakohene
Copy link
Collaborator

DorisAmoakohene commented Jan 29, 2024

by increasing N = 10^seq(1,7), this is the result I am getting

image

also is there a reason why descending cut at some point(1e05)?

@tdhock
Copy link
Owner Author

tdhock commented Jan 30, 2024

descending is cut because it went over seconds.limit

@tdhock
Copy link
Owner Author

tdhock commented Jan 30, 2024

is your result consistent with the original?

@DorisAmoakohene
Copy link
Collaborator

yes, it is

@tdhock
Copy link
Owner Author

tdhock commented May 8, 2024

please link to the code that you created and then close after

@tdhock tdhock reopened this May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants