-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TG2-VALIDATION_BASISOFRECORD_STANDARD #104
Comments
Comment by Arthur Chapman (@ArthurChapman) migrated from spreadsheet: |
… changing data values to be consistent with basis of record, adding explicit alternative vocabularies, clarifying human readable messages, adding column to specify source authority, adding cases for all valid vocabulary values, adding a range of cases for problematic values.
I just detected that the Specifications for this test was lacking "Darwin Core Class | Record_level Terms" so I have just added it. |
Added note to clarify the default source authority, since it isn't itself a list of vocaublary terms: See the dwc:basisOfRecord comment "Recommended best practice is to use the standard label of one of the Darwin Core classes." |
…ARD including DwCMetadataDQDefaults class for handling invocations of methods without specifying parameters when using defaults. Includes minimal unit test.
…RD using actual labels of Darwin Core classes, not the currently incorrect list in the examples for dwc:basisOfRecord.
… list of default accepted values.
Added note "This test will fail if there are leading or trailing white space or non-printing characters." |
Note comments at tdwg/dwc#416 |
Changed Source Authority from bdq:sourceAuthority default = "Darwin Core Terms" [https://dwc.tdwg.org/terms/#dwc:basisOfRecord] to bdq:sourceAuthority default = {Darwin Core} {Basis of record [https://dwc.tdwg.org/terms/#dwc:basisOfRecord] } and removed bdq:sourceAuthority from Parameters (I presume, as there is no alternative vocab)? |
Amended Source Authority values to align with @chicoreus syntax bdq:sourceAuthority default = {Darwin Core} {Basis of record [https://dwc.tdwg.org/terms/#dwc:basisOfRecord]} to bdq:sourceAuthority default = "Darwin Core dwc:basisOfRecord" {[https://dwc.tdwg.org/terms/#dwc:basisOfRecord]} |
Post Zoom 11/7/2023, I have aligned the Source Authority with the suggested syntax: bdq:sourceAuthority default = "Darwin Core dwc:basisOfRecord" {[https://dwc.tdwg.org/terms/#dwc:basisOfRecord]} to bdq:sourceAuthority default = "Darwin Core" {https://dwc.tdwg.org/} {dwc:basisOfRecord [https://dwc.tdwg.org/terms/#dwc:basisOfRecord]} |
Due to recent discussions, changed Source Authority from bdq:sourceAuthority default = "Darwin Core" {[https://dwc.tdwg.org/]} {dwc:basisOfRecord [https://dwc.tdwg.org/terms/#dwc:basisOfRecord]} to bdq:sourceAuthority default = "Darwin Core basisOfRecord" {[https://dwc.tdwg.org/terms/#dwc:basisOfRecord]}{Basis of record vocabulary [https://rs.gbif.org/vocabulary/dwc/basis_of_record.xml]} Notes needed by @tucotuco |
I missed the Parameter(s) (added) and the syntax on the vocabulary in Source Authority (done) |
Updated comment from "See the dwc:basisOfRecord comment "Recommended best practice is to use the standard label of one of the Darwin Core classes." This test will fail if there is leading or trailing whitespace or there are leading or trailing non-printing characters." to "The term dwc:basisOfRecord has the comment "Recommended best practice is to use the standard label of one of the Darwin Core classes." The list of these values can be determined by searching https://github.com/tdwg/dwc/blob/master/vocabulary/term_versions.csv for rows with status="recommended" and rdf_type="http://www.w3.org/2000/01/rdf-schema#Class". For tests against a dwc:Occurrence record, the set of valid terms is more limited and embodied in the resource found at https://rs.gbif.org/vocabulary/dwc/basis_of_record.xml. This test will fail if there is leading or trailing whitespace or there are leading or trailing non-printing characters." |
Splitting bdqffdq:Information Elements into "Information Elements ActedUpon" and "Information Elements Consulted". Also changed "Field" to "TestField", "Output Type" to "TestType" and updated "Specification Last Updated" |
Updated notes from "fail" to more specific "This test must return NOT_COMPLIANT if there is leading or trailing whitespace or there are leading or trailing non-printing characters. " |
…se of local name instead of label, also adding support for source authority detection and error handling.
The text was updated successfully, but these errors were encountered: