Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TG2-VALIDATION_TAXON_NOTEMPTY #105

Open
iDigBioBot opened this issue Jan 5, 2018 · 9 comments
Open

TG2-VALIDATION_TAXON_NOTEMPTY #105

iDigBioBot opened this issue Jan 5, 2018 · 9 comments
Labels
Completeness CORE TG2 CORE tests NAME Test Tests created by TG2, either CORE, Supplementary or DO NOT IMPLEMENT TG2 Validation

Comments

@iDigBioBot
Copy link
Collaborator

iDigBioBot commented Jan 5, 2018

TestField Value
GUID 06851339-843f-4a43-8422-4e61b9a00e75
Label VALIDATION_TAXON_NOTEMPTY
Description Is there a value in any of the terms needed to determine that the taxon exists?
TestType Validation
Darwin Core Class dwc:Taxon
Information Elements ActedUpon dwc:taxonID
dwc:scientificNameID
dwc:acceptedNameUsageID
dwc:parentNameUsageID
dwc:originalNameUsageID
dwc:taxonConceptID
dwc:scientificName
dwc:higherClassification
dwc:kingdom
dwc:phylum
dwc:class
dwc:order
dwc:superfamily
dwc:family
dwc:subfamily
dwc:tribe
dwc:subtribe
dwc:genus
dwc:genericName
dwc:subgenus
dwc:infragenericEpithet
dwc:specificEpithet
dwc:infraspecificEpithet
dwc:vernacularName
dwc:cultivarEpithet
Information Elements Consulted
Expected Response COMPLIANT if at least one term needed to determine the taxon of the entity exists and is NOT EMPTY; otherwise NOT_COMPLIANT
Data Quality Dimension Completeness
Term-Actions TAXON_NOTEMPTY
Parameter(s)
Source Authority
Specification Last Updated 2023-09-18
Examples [dwc:taxonID="", dwc:scientificNameID="", dwc:acceptedNameUsageID="", dwc:parentNameUsageID="", dwc:originalNameUsageID="", dwc:taxonConceptID="", dwc:scientificName="Eucalyptus gunnii", dwc:higherClassification="", dwc:kingdom="", dwc:phylum="", dwc:class="", dwc:order="", dwc:family="", dwc:genus="", dwc:subgenus="", dwc:specificEpithet="", dwc:infraspecificEpithet="", dwc:vernacularName="" : Response.status=RUN_HAS_RESULT, Response.result=COMPLIANT, Response.comment="at least enough terms exist that identify that an entity exists"]
[dwc:taxonID="", dwc:scientificNameID="", dwc:acceptedNameUsageID="", dwc:parentNameUsageID="", dwc:originalNameUsageID="", dwc:taxonConceptID="", dwc:scientificName="", dwc:higherClassification="", dwc:kingdom="", dwc:phylum="", dwc:class="", dwc:order="", dwc:family="", dwc:genus="", dwc:subgenus="", dwc:specificEpithet="", dwc:infraspecificEpithet="", dwc:vernacularName="": Response.status=RUN_HAS_RESULT, Response.result=NOT_COMPLIANT, Response.comment="All input fields are empty or missing"]
Source Lee Belbin
References
Example Implementations (Mechanisms)
Link to Specification Source Code
Notes This tests for records that have no taxonomic (NAME) information. If there is any value for any of the Information Elements, this may be useful information. See example.
@iDigBioBot
Copy link
Collaborator Author

Comment by Lee Belbin (@Tasilee) migrated from spreadsheet:
This needs discussion. For example, would kingdom, phylum, class or order only be useful?

@pzermoglio pzermoglio changed the title TG2-VALIDATION_NAME_NULL TG2-VALIDATION_TAXON_NULL Jan 18, 2018
@ArthurChapman ArthurChapman added the Test Tests created by TG2, either CORE, Supplementary or DO NOT IMPLEMENT label Jan 18, 2018
@ArthurChapman ArthurChapman changed the title TG2-VALIDATION_TAXON_NULL TG2-VALIDATION_TAXON_EMPTY Jan 29, 2018
ArthurChapman added a commit that referenced this issue Oct 6, 2020
In accord with #189 added TAXON_EMPTY #105
@Tasilee
Copy link
Collaborator

Tasilee commented Mar 11, 2022

Added new Darwin Core taxon terms to Information Elements. Are there any unnecessary ones?

@Tasilee Tasilee changed the title TG2-VALIDATION_TAXON_EMPTY TG2-VALIDATION_TAXON_NOTEMPTY Mar 22, 2022
@chicoreus
Copy link
Collaborator

chicoreus commented Jun 9, 2022

Following the definitions of the higher taxonomy terms being placements for the taxon, not the taxon, and as expresse in #57 and #70, the information elements in this test should exclude the higher taxonomy terms, and should reflect just the list as used in #57 and #70: dwc:taxonID, dwc:scientificName, dwc:genericName, dwc:specificEpithet, dwc:infraspecificEpithet, dwc:scientificNameAuthorship and dwc:cultivarEpithet. Perhaps also including dwc:taxonConceptID, and dwc:scientificNameID. This shorter list are the terms needed to "determine the taxon of the entity exists", others are placements for the taxon or relationships to other taxa.

chicoreus added a commit to FilteredPush/sci_name_qc that referenced this issue Jun 9, 2022
…n tests to current TG2 Specifications. DESCRIPTION: Updating implementations of VALIDATION_TAXONRANK_NOTEMPTY and VALIDATION_TAXON_NOTEMPTY (which needs work, specification includes classification terms)
@chicoreus
Copy link
Collaborator

Discussed in a call this summer, position is analogous to a date with just a day, there isn't sufficient information to know which day is being talked about, but there is some information that constrains the date. Thus even just a value in kingdom (a classification term) is adequate to provide some constraints on the taxon. Thus retain the current list of information elements, not try to reduced.

chicoreus added a commit to FilteredPush/sci_name_qc that referenced this issue Jun 26, 2023
…tdwg/bdq specifications. Updated metadata (added ProvidesVersion and Specification) for tdwg/bdq#105 VALIDATION_TAXON_NOTEMPTY. Added dwc:order and dwc:cultivarEpithet to method.
@chicoreus
Copy link
Collaborator

Will need to include the new terms dwc:superfamily, dwc:tribe, dwc:subtribe tdwg/dwc#65 tdwg/dwc#45 tdwg/dwc#46

@Tasilee
Copy link
Collaborator

Tasilee commented Jul 4, 2023

Added the terms dwc:superfamily, dwc:tribe, dwc:subtribe to the Information elements.

@Tasilee Tasilee removed the NEEDS WORK label Jul 4, 2023
@chicoreus
Copy link
Collaborator

Updated the date last updated to 2022-07-04 as the list of information elements has changed.

chicoreus added a commit that referenced this issue Jul 10, 2023
…w copy of the test specifications as of 2023-07-10, updating data for #105 VALIDATION_TAXON_NOTEMPTY, where specification had changed but date last modified had not.
chicoreus added a commit to FilteredPush/sci_name_qc that referenced this issue Jul 10, 2023
…h turtle representation to reflect current (2023-07-10) specifications, including corrected date last modified for tdwg/bdq#105.
chicoreus added a commit to FilteredPush/sci_name_qc that referenced this issue Jul 10, 2023
…pecifications. Addressed tdwg/bdq#105 VALIDATION_TAXON_NOTEMPTY added superfamily, tribe, subtribe to Taxon class.  Added unit test to confirm alignment of list of string parameters in Taxon constructor with underlying fields.  Updated invocations of Taxon constructor to pass in these parameters.  Added these fields to unit test for VALIDATION_TAXON_NOTEMPTY, updated method to pass unit test.
@Tasilee
Copy link
Collaborator

Tasilee commented Jul 10, 2023

Amended Specification Last Updated from "2022-07-04" to "2023-07-04" :)

@Tasilee
Copy link
Collaborator

Tasilee commented Sep 18, 2023

Splitting bdqffdq:Information Elements into "Information Elements ActedUpon" and "Information Elements Consulted".

Also changed "Field" to "TestField", "Output Type" to "TestType" and updated "Specification Last Updated"

@chicoreus chicoreus added the CORE TG2 CORE tests label Sep 18, 2023
chicoreus added a commit to FilteredPush/sci_name_qc that referenced this issue Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Completeness CORE TG2 CORE tests NAME Test Tests created by TG2, either CORE, Supplementary or DO NOT IMPLEMENT TG2 Validation
Development

No branches or pull requests

4 participants