Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TG2-VALIDATION_MINDEPTH_LESSTHAN_MAXDEPTH #24

Open
iDigBioBot opened this issue Jan 5, 2018 · 9 comments
Open

TG2-VALIDATION_MINDEPTH_LESSTHAN_MAXDEPTH #24

iDigBioBot opened this issue Jan 5, 2018 · 9 comments
Labels
Conformance CORE TG2 CORE tests SPACE Test Tests created by TG2, either CORE, Supplementary or DO NOT IMPLEMENT TG2 Validation

Comments

@iDigBioBot
Copy link
Collaborator

iDigBioBot commented Jan 5, 2018

TestField Value
GUID 8f1e6e58-544b-4365-a569-fb781341644e
Label VALIDATION_MINDEPTH_LESSTHAN_MAXDEPTH
Description Is the value of dwc:minimumDepthInMeters a number that is less than or equal to the value of dwc:maximumDepthInMeters?
TestType Validation
Darwin Core Class Location
Information Elements ActedUpon dwc:minimumDepthInMeters
dwc:maximumDepthInMeters
Information Elements Consulted
Expected Response INTERNAL_PREREQUISITES_NOT_MET if dwc:minimumDepthInMeters or dwc:maximumDepthInMeters is EMPTY, or if either are interpretable as not zero or a positive number; COMPLIANT if the value of dwc:minimumDepthInMeters is less than or equal to the value of dwc:maximumDepthInMeters; otherwise NOT_COMPLIANT
Data Quality Dimension Conformance
Term-Actions MINDEPTH_LESSTHAN_MAXDEPTH
Parameter(s)
Source Authority
Specification Last Updated 2023-09-18
Examples [dwc:minimumDepthInMeters="0", dwc:maximumDepthInMeters="0": Response.status=RUN_HAS_RESULT, Response.result=COMPLIANT, Response.comment="dwc:minimumDepthInMeters = dwc:maximumDepthInMeters"]
[dwc:minimumDepthInMeters="1", dwc:maximumDepthInMeters="0": Response.status=RUN_HAS_RESULT, Response.result=NOT_COMPLIANT, Response.comment="dwc:minimumDepthInMeters > dwc:maximumDepthInMeters"]
Source ALA, GBIF, OBIS
References
Example Implementations (Mechanisms)
Link to Specification Source Code
Notes
@iDigBioBot
Copy link
Collaborator Author

Comment by Paula Zermoglio (@pzermoglio) migrated from spreadsheet:
This is assuming that depths are actually correct but transposed, rather than just one of them, maximum or minimum being just plainly wrong.

@iDigBioBot
Copy link
Collaborator Author

Comment by Paul Morris (@chicoreus) migrated from spreadsheet:
Separate into a validation MIN_DEPTH_SHALLOWERTHAN_OR_EQ_MAX and an amendment MIN_MAX_DEPTHS_TRANSPOSED, to resolve the issue. There's a validation to find problematic depths, and an amendment which makes the explictit assumption that there is a transposition, make the transpostion, and leaves the consumer of the report free to decide whether or not to accept that assumption. A transposition ammendment could also be expected to be informed by a ocean depth model and only propose the transposition if it is reasonable for the location and geographic uncertainty. A nearshore depth where a minimum depth has an error in the form of a missing decimal point making it much larger than the maximum depth is a very plausible error on the line PZ considers.

@iDigBioBot
Copy link
Collaborator Author

Comment by Lee Belbin (@Tasilee) migrated from spreadsheet:
Basically, the statement needs to be min max depths ok

@iDigBioBot
Copy link
Collaborator Author

Comment by Paul Morris (@chicoreus) migrated from spreadsheet:
Split into separate Validation and Amendment, Validation=1, amendment needs more specification.

@chicoreus
Copy link
Collaborator

Splits have been accomplished. This test is now atomic so comments about splits have been satisfied.

@ArthurChapman ArthurChapman added the Test Tests created by TG2, either CORE, Supplementary or DO NOT IMPLEMENT label Jan 16, 2018
@chicoreus
Copy link
Collaborator

Output Type is missing from the Field/Value table. @Tasilee please correct (looks like it should be Output Type = Validation) and review table for any other errors.

@Tasilee
Copy link
Collaborator

Tasilee commented Aug 7, 2019

Thanks @chicoreus. Done.

@Tasilee Tasilee changed the title TG2-VALIDATION_MINDEPTH_GREATERTHAN_MAXDEPTH TG2-VALIDATION_MINDEPTH_LESSTHAN_MAXDEPTH Mar 22, 2022
chicoreus added a commit to FilteredPush/geo_ref_qc that referenced this issue Jun 20, 2023
…st current (2023-06-12) test descriptions. Addressed implementation of tdwg/bdq#24 VALIDATION_MINDEPTH_LESSTHAN_MAXDEPTH Adding ProvidesVersion annotations. Made method name consistent with test name.  Removing now empty file stubs for checked methods.
@Tasilee
Copy link
Collaborator

Tasilee commented Sep 16, 2023

Splitting bdqffdq:Information Elements into "Information Elements ActedUpon" and "Information Elements Consulted". Is this one correct?

@chicoreus
Copy link
Collaborator

Both dwc:minimumDepthInMeters and dwc:maximumDepthInMeters are ActedUpon, as if NOT_COMPLIANT, the test isn't able to tell which is incorrect, so both need to be marked in the same way.

@chicoreus chicoreus added the CORE TG2 CORE tests label Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Conformance CORE TG2 CORE tests SPACE Test Tests created by TG2, either CORE, Supplementary or DO NOT IMPLEMENT TG2 Validation
Development

No branches or pull requests

4 participants