Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TG2-VALIDATION_MINELEVATION_LESSTHAN_MAXELEVATION #108

Open
iDigBioBot opened this issue Jan 5, 2018 · 9 comments
Open

TG2-VALIDATION_MINELEVATION_LESSTHAN_MAXELEVATION #108

iDigBioBot opened this issue Jan 5, 2018 · 9 comments
Labels
Conformance CORE TG2 CORE tests SPACE Test Tests created by TG2, either CORE, Supplementary or DO NOT IMPLEMENT TG2 Validation

Comments

@iDigBioBot
Copy link
Collaborator

iDigBioBot commented Jan 5, 2018

TestField Value
GUID d708526b-6561-438e-aa1a-82cd80b06396
Label VALIDATION_MINELEVATION_LESSTHAN_MAXELEVATION
Description Is the value of dwc:minimumElevationInMeters a number less than or equal to the value of dwc:maximumElevationInMeters?
TestType Validation
Darwin Core Class dcterms:Location
Information Elements ActedUpon dwc:minimumElevationInMeters
dwc:maximumElevationInMeters
Information Elements Consulted
Expected Response INTERNAL_PREREQUISITES_NOT_MET if dwc:maximumlevationInMeters or dwc:minimumElevationInMeters is EMPTY, or if either is not a number; COMPLIANT if the value of dwc:minimumElevationInMeters is a number less than or equal to the value of the number dwc:maximumElevationInMeters, otherwise NOT_COMPLIANT
Data Quality Dimension Conformance
Term-Actions MINELEVATION_LESSTHAN_MAXELEVATION
Parameter(s)
Source Authority
Specification Last Updated 2023-09-18
Examples [dwc:minimumElevationInMeters="0", dwc:maximumElevationInMeters="0": Response.status=RUN_HAS_RESULT, Response.result=COMPLIANT, Response.comment="dwc:minimumElevationInMeters is equal to dwc: maximumElevationInMeters"]
[dwc:minimumElevationInMeters="1", dwc:maximumElevationInMeters="0": Response.status=RUN_HAS_RESULT, Response.result=NOT_COMPLIANT, Response.comment="dwc:minimumElevationInMeters is greater than dwc:maximumElevationInMeters"]
Source @Tasilee
References
Example Implementations (Mechanisms)
Link to Specification Source Code
Notes
@iDigBioBot
Copy link
Collaborator Author

Comment by Lee Belbin (@Tasilee) migrated from spreadsheet:
Validation equivalent to amendment

@ArthurChapman ArthurChapman added the Test Tests created by TG2, either CORE, Supplementary or DO NOT IMPLEMENT label Jan 17, 2018
@chicoreus
Copy link
Collaborator

chicoreus commented Feb 19, 2022

For consistency with #112 and #39 and #24 should probably have internal prerequisites not met if either of the information elements has a value that is not a number.

Propose changing:

INTERNAL_PREREQUISITES_NOT_MET if dwc:maximumlevationInMeters or dwc:minimumElevationInMeters is EMPTY; COMPLIANT if the value of dwc:minimumElevationInMeters is a number less than or equal to the value of the number dwc:maximumElevationInMeters, otherwise NOT_COMPLIANT

To:

INTERNAL_PREREQUISITES_NOT_MET if dwc:maximumlevationInMeters or dwc:minimumElevationInMeters is EMPTY or either is not a number; COMPLIANT if the value of dwc:minimumElevationInMeters is a number less than or equal to the value of the number dwc:maximumElevationInMeters, otherwise NOT_COMPLIANT

@ArthurChapman
Copy link
Collaborator

Agree

@tucotuco
Copy link
Member

tucotuco commented Feb 20, 2022 via email

@Tasilee
Copy link
Collaborator

Tasilee commented Feb 21, 2022

I agree and have made the change.

@Tasilee
Copy link
Collaborator

Tasilee commented Feb 21, 2022

I note that we have used here "is not a number;" but elsewhere (e.g., #87) we use "interpretable as a number". How do you want to play this? I'd opt for the former (Occam).

Also, I presume the ER would also apply to #24?

@tucotuco
Copy link
Member

"is a number" sounds simple even if it might not be as rigorously correct. An example would be for the month field because entomologists use Roman numerals, but we say "is an integer" there, so it seems perfectly reasonable to say "is a number" here.

I'm not sure what you mean by "also apply to #24", but certainly the pattern should be consistent.

@Tasilee
Copy link
Collaborator

Tasilee commented Feb 21, 2022

I have aligned the Expected Response of #24 with this one.

@Tasilee Tasilee changed the title TG2-VALIDATION_MINELEVATION_GREATERTHAN_MAXELEVATION TG2-VALIDATION_MINELEVATION_LESSTHAN_MAXELEVATION Mar 22, 2022
@Tasilee Tasilee removed the NEEDS WORK label Apr 3, 2022
chicoreus added a commit to FilteredPush/geo_ref_qc that referenced this issue Sep 6, 2022
…n (now testing for number as well as not empty) with comments and minimal unit test. Also fixed name of validationMindepthInrange to be consistent with test name.
chicoreus added a commit to FilteredPush/geo_ref_qc that referenced this issue Jun 16, 2023
…st current (2023-06-12) test descriptions. Addressed implementation of tdwg/bdq#108 VALIDATION_MINELEVATION_LESSTHAN_MAXELEVATION   Adding ProvidesVersion annotations.   Removing now empty file stubs for checked methods.  Adding some unit tests.
@Tasilee
Copy link
Collaborator

Tasilee commented Sep 18, 2023

Splitting bdqffdq:Information Elements into "Information Elements ActedUpon" and "Information Elements Consulted".

Also changed "Field" to "TestField", "Output Type" to "TestType" and updated "Specification Last Updated"

@chicoreus chicoreus added the CORE TG2 CORE tests label Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Conformance CORE TG2 CORE tests SPACE Test Tests created by TG2, either CORE, Supplementary or DO NOT IMPLEMENT TG2 Validation
Development

No branches or pull requests

5 participants