-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TG2-VALIDATION_MINELEVATION_LESSTHAN_MAXELEVATION #108
Comments
Comment by Lee Belbin (@Tasilee) migrated from spreadsheet: |
For consistency with #112 and #39 and #24 should probably have internal prerequisites not met if either of the information elements has a value that is not a number. Propose changing: INTERNAL_PREREQUISITES_NOT_MET if dwc:maximumlevationInMeters or dwc:minimumElevationInMeters is EMPTY; COMPLIANT if the value of dwc:minimumElevationInMeters is a number less than or equal to the value of the number dwc:maximumElevationInMeters, otherwise NOT_COMPLIANT To: INTERNAL_PREREQUISITES_NOT_MET if dwc:maximumlevationInMeters or dwc:minimumElevationInMeters is EMPTY or either is not a number; COMPLIANT if the value of dwc:minimumElevationInMeters is a number less than or equal to the value of the number dwc:maximumElevationInMeters, otherwise NOT_COMPLIANT |
Agree |
Agree
…On Sat, Feb 19, 2022 at 7:28 PM Arthur Chapman ***@***.***> wrote:
Agree
—
Reply to this email directly, view it on GitHub
<#108 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADQ725ODWSFJZGJX2YQJKTU4AKRNANCNFSM4EKSRYRA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
I agree and have made the change. |
"is a number" sounds simple even if it might not be as rigorously correct. An example would be for the month field because entomologists use Roman numerals, but we say "is an integer" there, so it seems perfectly reasonable to say "is a number" here. I'm not sure what you mean by "also apply to #24", but certainly the pattern should be consistent. |
I have aligned the Expected Response of #24 with this one. |
…n (now testing for number as well as not empty) with comments and minimal unit test. Also fixed name of validationMindepthInrange to be consistent with test name.
…st current (2023-06-12) test descriptions. Addressed implementation of tdwg/bdq#108 VALIDATION_MINELEVATION_LESSTHAN_MAXELEVATION Adding ProvidesVersion annotations. Removing now empty file stubs for checked methods. Adding some unit tests.
Splitting bdqffdq:Information Elements into "Information Elements ActedUpon" and "Information Elements Consulted". Also changed "Field" to "TestField", "Output Type" to "TestType" and updated "Specification Last Updated" |
The text was updated successfully, but these errors were encountered: