Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TG2-VALIDATION_DATEIDENTIFIED_STANDARD #69

Open
iDigBioBot opened this issue Jan 5, 2018 · 5 comments
Open

TG2-VALIDATION_DATEIDENTIFIED_STANDARD #69

iDigBioBot opened this issue Jan 5, 2018 · 5 comments
Labels
CODED Conformance CORE TG2 CORE tests ISO/DCMI STANDARD Test Tests created by TG2, either CORE, Supplementary or DO NOT IMPLEMENT TG2 TIME Validation

Comments

@iDigBioBot
Copy link
Collaborator

iDigBioBot commented Jan 5, 2018

TestField Value
GUID 66269bdd-9271-4e76-b25c-7ab81eebe1d8
Label VALIDATION_DATEIDENTIFIED_STANDARD
Description Is the value of dwc:dateIdentified a valid ISO date?
TestType Validation
Darwin Core Class Identification
Information Elements ActedUpon dwc:dateIdentified
Information Elements Consulted
Expected Response INTERNAL_PREREQUISITES_NOT_MET if dwc:dateIdentified is EMPTY; COMPLIANT if the value of dwc:dateIdentified contains a valid ISO 8601-1 date; otherwise NOT_COMPLIANT
Data Quality Dimension Conformance
Term-Actions DATEIDENTIFIED_STANDARD
Parameter(s)
Source Authority
Specification Last Updated 2023-09-18
Examples [dwc:dateIdentified="1963-03-08T14:07": Response.status=RUN_HAS_RESULT, Response.result=COMPLIANT, Response.comment="dwc:dateIdentified is a valid ISO 8601-1:2019 date"]
[dwc:dateIdentified="1963-03-08X14:07-0600": Response.status=RUN_HAS_RESULT, Response.result=NOT_COMPLIANT, Response.comment="dwc:dateIdentified is not a valid ISO 8601-1:2019 date"]
Source
References
Example Implementations (Mechanisms) Kurator:event_date_qc
Link to Specification Source Code event_date_qc DwCOtherDateDQ.validationDateidentifiedStandard()
Notes
@iDigBioBot
Copy link
Collaborator Author

Comment by Lee Belbin (@Tasilee) migrated from spreadsheet:
Added post scoring for completeness

@ArthurChapman ArthurChapman added VOCABULARY Test Tests created by TG2, either CORE, Supplementary or DO NOT IMPLEMENT and removed VOCABULARY labels Jan 17, 2018
@Tasilee Tasilee changed the title TG2-VALIDATION_DATEIDENTIFIED_NOTSTANDARD TG2-VALIDATION_DATEIDENTIFIED_STANDARD Mar 22, 2022
@Tasilee
Copy link
Collaborator

Tasilee commented Mar 10, 2023

Changing

INTERNAL_PREREQUISITES_NOT_MET if dwc:dateIdentified is EMPTY; COMPLIANT if the value of dwc:dateIdentified is a valid according to bdq:sourceAuthority; otherwise NOT_COMPLIANT

to

INTERNAL_PREREQUISITES_NOT_MET if dwc:dateIdentified is EMPTY; COMPLIANT if dwc:dateIdentified contains a valid ISO 8601-1 date; otherwise NOT_COMPLIANT

Reasoning as per recent discussions, ISO 8601 is a format standard, not a lookup vocabulary (which would require an EXTERNAL_PREREQUISITES_NOT_MET). So I will also remove the bdq:sourceAuthority.

@Tasilee
Copy link
Collaborator

Tasilee commented Mar 26, 2023

I've edited the Expected Response according to @tucotuco suggestion:

From

INTERNAL_PREREQUISITES_NOT_MET if dwc:dateIdentified is EMPTY; COMPLIANT if dwc:dateIdentified contains a valid ISO 8601-1 date; otherwise NOT_COMPLIANT

to

INTERNAL_PREREQUISITES_NOT_MET if dwc:dateIdentified is EMPTY; COMPLIANT if the value of dwc:dateIdentified is a valid ISO 8601-1 date; otherwise NOT_COMPLIANT

and updated the References

@Tasilee
Copy link
Collaborator

Tasilee commented Mar 29, 2023

I have updated the ISO Reference link

@chicoreus chicoreus added the CODED label Jun 9, 2023
@Tasilee
Copy link
Collaborator

Tasilee commented Sep 18, 2023

Splitting bdqffdq:Information Elements into "Information Elements ActedUpon" and "Information Elements Consulted".

Also changed "Field" to "TestField", "Output Type" to "TestType" and updated "Specification Last Updated"

@chicoreus chicoreus added the CORE TG2 CORE tests label Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CODED Conformance CORE TG2 CORE tests ISO/DCMI STANDARD Test Tests created by TG2, either CORE, Supplementary or DO NOT IMPLEMENT TG2 TIME Validation
Development

No branches or pull requests

4 participants