Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TG2-ISSUE_DATAGENERALIZATIONS_NOTEMPTY #72

Open
iDigBioBot opened this issue Jan 5, 2018 · 20 comments
Open

TG2-ISSUE_DATAGENERALIZATIONS_NOTEMPTY #72

iDigBioBot opened this issue Jan 5, 2018 · 20 comments
Labels
CORE TG2 CORE tests Issue A potential issue NAME Resolution SPACE Test Tests created by TG2, either CORE, Supplementary or DO NOT IMPLEMENT TG2 TIME

Comments

@iDigBioBot
Copy link
Collaborator

iDigBioBot commented Jan 5, 2018

TestField Value
GUID 13d5a10e-188e-40fd-a22c-dbaa87b91df2
Label ISSUE_DATAGENERALIZATIONS_NOTEMPTY
Description Is there a value in dwc:dataGeneralizations?
TestType Issue
Darwin Core Class Record-level
Information Elements ActedUpon dwc:dataGeneralizations
Information Elements Consulted
Expected Response POTENTIAL_ISSUE if dwc:dataGeneralizations is not EMPTY; otherwise NOT_ISSUE
Data Quality Dimension Resolution
Term-Actions DATAGENERALIZATIONS_NOTEMPTY
Parameter(s)
Source Authority
Specification Last Updated 2023-09-18
Examples [dwc:dataGeneralizations="placed on quarter degree grid": Response.status=RUN_HAS_RESULT, Response.result=POTENTIAL_ISSUE, Response.comment="dwc:dataGeneralizations is not EMPTY"]
[dwc:dataGeneralizations="": Response.status=RUN_HAS_RESULT, Response.result=NOT_ISSUE, Response.comment="dwc:dataGeneralizations is EMPTY"]
Source ALA
References
Example Implementations (Mechanisms)
Link to Specification Source Code
Notes This is not specific to spatial data, any value in the dwc:dataGeneralizations field will cause this flag to be raised, but the primary use case is expected to be that dwc:dataGeneralizations demonstrates obfuscated locations.
@iDigBioBot
Copy link
Collaborator Author

Comment by Paula Zermoglio (@pzermoglio) migrated from spreadsheet:
Data generalizations can apply to non-geographic data, maybe the description of this test could be changed to match a more general approach, more in line with the name of the test.

@iDigBioBot
Copy link
Collaborator Author

Comment by Arthur Chapman (@ArthurChapman) migrated from spreadsheet:
Agreed @pjm - but it is important to include a test for this - Definitely a Core test

@iDigBioBot
Copy link
Collaborator Author

Comment by Arthur Chapman (@ArthurChapman) migrated from spreadsheet:
Perhaps this needs to be split inter several - e.g. LOCALITY_GENERALIZED, DATE_GENERALIZED, ?NAME_GENERALIZED - does that ever happen?

@iDigBioBot
Copy link
Collaborator Author

Comment by Arthur Chapman (@ArthurChapman) migrated from spreadsheet:
I believe that this should be altered to a NOTIFICATION rather than a VALIDATION

@ArthurChapman ArthurChapman added the Test Tests created by TG2, either CORE, Supplementary or DO NOT IMPLEMENT label Jan 17, 2018
@godfoder godfoder changed the title TG2-VALIDATION_DATAGENERALIZATIONS_NOTNULL TG2-VALIDATION_DATAGENERALIZATIONS_NOTEMPTY Jan 17, 2018
@godfoder godfoder changed the title TG2-VALIDATION_DATAGENERALIZATIONS_NOTEMPTY TG2-NOTIFICATION_DATAGENERALIZATIONS_NOTEMPTY Jan 17, 2018
@ArthurChapman ArthurChapman added Issue A potential issue and removed Validation labels Jan 17, 2018
@Tasilee
Copy link
Collaborator

Tasilee commented Aug 14, 2018

I can see a case for NAME (higher taxonomy) and SPACE (lower spatial resolution), but do we have any precedent or examples for TIME? I can't think of any.

@ArthurChapman
Copy link
Collaborator

Maybe someone doesn't want people to know where they were on a particular day? In our data sensitivity document I don't think we considered TIME. But there may be some that don't want it known what days certain animals hatch - turtles on a particular beach, for example. Not sure, but if it is the one tests does it hurt to include?

@Tasilee
Copy link
Collaborator

Tasilee commented Aug 14, 2018

I'm ok with leaving TIME in and I'll be interested to hear other comments.

@cgendreau
Copy link

I would keep TIME but I'm not sure about mixing the 3 under the same test. But since there is only 1 Dwc term, maybe that's enough for now.

@ArthurChapman ArthurChapman moved this from OTHER TESTS to GENERAL TESTS in Core Tests and Assertions (TG2) Aug 27, 2018
@ArthurChapman
Copy link
Collaborator

In this record - the Dimension - should be "Other" and not "Space, Time, Name" - as although it does refer to data generalizations in those three "Dimensions" the actual dwc Element it refers to (dwc:dataGeneralizations falls into the "Other" category. See separate Issue I am posting shortly

@Tasilee
Copy link
Collaborator

Tasilee commented Sep 7, 2018

My feeling is that we are using Dimension as a way of summarising the coverage of the tests, so while the term dwc:dataGeneralizations could be considered agnostic based on http://rs.tdwg.org/dwc/terms/#dataGeneralizations, we agreed to specifically allow this test to cover name, space and time. I find that a more useful strategy - and this is an issue for the Darwin Core Maintenance Group to review.

@tucotuco
Copy link
Member

tucotuco commented Sep 7, 2018

@Tasilee What needs review from the Darwin Core Maintenance Group?

@Tasilee
Copy link
Collaborator

Tasilee commented Sep 7, 2018

@tucotuco: I was wondering if the recent acceptance of dwc:dataGeneralisations to name, time beyond space would benefit from being more explicit? I also seem to remember that we did have a few (non github) issues from Gainesville for DwC? Chasing...

@ArthurChapman
Copy link
Collaborator

I think you mean dwc:dataGeneralizations, Lee

@Tasilee
Copy link
Collaborator

Tasilee commented Sep 7, 2018

yes, tired. @ArthurChapman do you remember any other issues from TG2 for Dwc?

@ArthurChapman
Copy link
Collaborator

Not off hand. I am sure @tucotuco made notes in Gainesville of anything relevant to DwC

@tucotuco
Copy link
Member

Darwin Core does not have these concepts of Dimension, nor is dwc:dataGeneralizations limited to those three data quality concepts. I see the data quality standard as a layer applied on top of Darwin Core (or other standards where the terms are equivalent), and that Darwin Core itself must remain defined independently of that layer.

Tasilee added a commit that referenced this issue Oct 6, 2020
In accordance with #189, added file testdata_NOTIFICATION_DATAGENERALIZATIONS_NOTEMPTY_#72 for #72
@Tasilee Tasilee changed the title TG2-NOTIFICATION_DATAGENERALIZATIONS_NOTEMPTY TG2-ISSUE_DATAGENERALIZATIONS_NOTEMPTY Mar 21, 2022
@Tasilee
Copy link
Collaborator

Tasilee commented Mar 21, 2022

As per meeting 21st March, NOTIFICATIONs will now be ISSUEs.

@Tasilee
Copy link
Collaborator

Tasilee commented May 15, 2022

After zoom meeting, changed

POTENTIAL_ISSUE if dwc:dataGeneralizations is not EMPTY; otherwise NO_ISSUE

to

POTENTIAL_ISSUE if dwc:dataGeneralizations is not EMPTY; otherwise NOT_ISSUE

chicoreus added a commit to FilteredPush/geo_ref_qc that referenced this issue Jun 7, 2022
…RIPTION: Adding implementation and unit test for ISSUE_DATAGENERALIZATIONS_NOTEMPTY tdwg/bdq#72.
chicoreus added a commit to FilteredPush/rec_occur_qc that referenced this issue Jun 9, 2023
@chicoreus chicoreus added the CORE TG2 CORE tests label Sep 18, 2023
@ymgan
Copy link
Collaborator

ymgan commented Jan 15, 2024

From 1.5 About the tests, their use and specifications (Informative) (Lee)

  1. Value is the returned result for the test, i.e. numeric for measures, a controlled vocabulary (consisting of exactly COMPLIANT or NOT_COMPLIANT) for validations or Issues (NOT_ISSUE, POSSIBLE_ISSUE, ISSUE), either a numeric value or a controlled vocabulary (consisting of exactly COMPLETE or NOT_COMPLETE for Measures, and a data structure (e.g., a list of key value pairs) for proposed changes for Amendments.

Expected Response in this issue:

  • uses POTENTIAL_ISSUE, but the text in standards document is POSSIBLE_ISSUE

@ArthurChapman
Copy link
Collaborator

ArthurChapman commented Jan 15, 2024

Thanks @ymgan POTENTIAL_ISSUE is correct (see Vocabulary Document at #152 Document needs fixing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CORE TG2 CORE tests Issue A potential issue NAME Resolution SPACE Test Tests created by TG2, either CORE, Supplementary or DO NOT IMPLEMENT TG2 TIME
Projects
Development

No branches or pull requests

7 participants