Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

on_enter is called after pause and stop execution #103

Closed
Achllle opened this issue Jan 30, 2020 · 2 comments
Closed

on_enter is called after pause and stop execution #103

Achllle opened this issue Jan 30, 2020 · 2 comments
Assignees
@pschillinger
Labels
resolved on develop Resolved on the development branch, no further work expected.

Comments

@Achllle
Copy link
Contributor

Achllle commented Jan 30, 2020

Description

When you pause a state, say an action client, and then click on 'Stop Execution', the on_enter method gets called.

I would say this is unwanted behavior, since you can't cancel the now continuing execution anymore.
@pschillinger
Copy link
Member

When I tried to replicate, I observed the following event sequence:

  • on_pause
  • (clicked "Stop Execution")
  • on_resume
  • on_exit
  • on_stop

Still, on_resume and on_exit should both not be required here.

@pschillinger pschillinger self-assigned this Feb 1, 2020
pschillinger added a commit that referenced this issue Feb 1, 2020
@pschillinger
Do not trigger on_resume and on_exit when stopped during pause
1ba1b73 
(see #103)
@pschillinger pschillinger added the resolved on develop Resolved on the development branch, no further work expected. label Feb 9, 2020
@pschillinger
Copy link
Member

Released with 1.2.4

@fgreen fgreen mentioned this issue May 26, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pschillinger pschillinger

Labels
resolved on develop Resolved on the development branch, no further work expected.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pschillinger @Achllle