Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bit status shows truncated ids for scss deps with scope #3663

Closed
KutnerUri opened this issue Jan 18, 2021 · 0 comments · Fixed by #4222
Closed

bit status shows truncated ids for scss deps with scope #3663

KutnerUri opened this issue Jan 18, 2021 · 0 comments · Fixed by #4222
Assignees
@davidfirst
Labels
type/bug

Comments

@KutnerUri
Copy link
Contributor

I have a dependency between scss files. The dependency resolution works well, but the output is truncated:

     > ui/notifications/notification-center ...  issues found       
       missing packages dependencies (make sure you've added it to the package dependencies, and use `bit install` to make sure all package dependencies are installed): 
          notification-center.module.scss -> ~@teambit

should be: @teambit/ui.constants.z-indexes (removing the ~ prefix or any files)

Specifications

  • Bit version: 14.8.9-dev.269 (also happens in main release)
@KutnerUri KutnerUri changed the title bit status shows only @scope/ for missing dependencies bit status shows truncated ids for scss deps with scope Jan 18, 2021
davidfirst added a commit that referenced this issue May 4, 2021
@davidfirst
resolve #3663, fix bit-status to show missing scoped packages with ti…
05e7597 
…lda correctly
@davidfirst davidfirst mentioned this issue May 4, 2021
Merged
@GiladShoham GiladShoham assigned davidfirst and unassigned GiladShoham May 4, 2021
davidfirst added a commit that referenced this issue May 4, 2021
@davidfirst
Fix bit-status to show missing scoped packages with tilda correctly (#…
97eadcb 
…4222)

Resolves #3663.

Currently, if the import statement has something like this: ~@teambit/base-ui.theme.colors/colors.module.scss and the package is not installed, it shows only ~@teambit.
This PR fixes it to show the full package-name @teambit/base-ui.theme.colors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davidfirst davidfirst

Labels
type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix bit-status to show missing scoped packages with tilda correctly teambit/bit
3 participants
@davidfirst @GiladShoham @KutnerUri