Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove refresh_user_locations from seed.py #576

Merged
merged 3 commits into from
Jan 13, 2021

Conversation

michielderoos
Copy link
Contributor

Describe the Pull Request

Don't merge this until #555 is deployed into prod
This just removes a one-time address fix from the DB seed script!

Todo

@michielderoos
Copy link
Contributor Author

@codecov
Copy link

codecov bot commented Dec 8, 2020

Codecov Report

Merging #576 (8ff609b) into master (b7e6558) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #576   +/-   ##
=======================================
  Coverage   48.14%   48.15%           
=======================================
  Files         336      336           
  Lines       17631    17624    -7     
  Branches     1374     1312   -62     
=======================================
- Hits         8488     8486    -2     
- Misses       9110     9123   +13     
+ Partials       33       15   -18     
Flag Coverage Δ
javascript 4.75% <ø> (ø)
python 71.81% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
app/migrations/seed.py 65.60% <ø> (+2.19%) ⬆️
config.py 83.15% <100.00%> (ø)
app/server/utils/mock_data.py 79.11% <0.00%> (-0.64%) ⬇️
app/client/reducers/auth/reducers.ts 0.00% <0.00%> (ø)
app/client/reducers/user/reducers.ts 0.00% <0.00%> (ø)
app/client/reducers/wyre/reducers.ts 0.00% <0.00%> (ø)
app/client/reducers/filter/reducers.ts 0.00% <0.00%> (ø)
app/client/reducers/metric/reducers.ts 0.00% <0.00%> (ø)
app/client/reducers/auth/loginReducer.ts 0.00% <0.00%> (ø)
app/client/components/helpers/responsive.tsx 0.00% <0.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7e6558...8ff609b. Read the comment docs.

Copy link
Contributor

@enjeyw enjeyw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go!

@michielderoos michielderoos merged commit f2aacde into master Jan 13, 2021
@michielderoos michielderoos deleted the remove-refresh-locations-from-seed branch January 13, 2021 15:18
enjeyw added a commit that referenced this pull request Jan 15, 2021
* master: (27 commits)
  Minimum withdrawal amount (#528)
  Remove refresh_user_locations from seed.py (#576)
  Search 2.0 (#581)
  Re-implements the XLSX/CSV uploader (#575)
  Fix to make sure custom attributes are included on export (#592)
  Bump cairosvg from 2.4.2 to 2.5.1 in /app (#590)
  Remove orjson requirement (#591)
  URL Builder for Kobo/Commcare Integrations (#578)
  Re-Enable Caching for Metrics (#532)
  Do the thing (#589)
  fix: mock data error (#582)
  style: improve view only functionality (#587)
  Fix null subtraction error (#586)
  Don't make index if it's already there (#584)
  Circle was being weird. This fixes it! (#588)
  Transfer Card Fetching Improvements (#580)
  Make map work again (#577)
  Stop requiring chains and default_chain in config files (#579)
  Adding blockchain_task_uuid index to worker messages (#551)
  Make location lookup look at existing users' coordinates as a last resort (#555)
  ...

# Conflicts:
#	.circleci/config.yml
#	config.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants