Make location lookup look at existing users' coordinates as a last resort #555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #555 +/- ##
===========================================
+ Coverage 16.98% 47.22% +30.23%
===========================================
Files 199 337 +138
Lines 7787 17600 +9813
Branches 1348 1347 -1
===========================================
+ Hits 1323 8312 +6989
- Misses 6431 9255 +2824
Partials 33 33
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
tristanhcole
approved these changes
Dec 8, 2020
Comment on lines
+424
to
+425
| refresh_user_locations(current_app) | ||
|
|
There was a problem hiding this comment.
do we want to be running this on every app launch?
There was a problem hiding this comment.
I think so. It's not a task well suited to migrations, and we have a task queued to remove it once this PR makes it into prod
Comment on lines
+27
to
+28
| Checks if another user has a manually set coords for a given location name. | ||
| If they do, steal them! |
|
HAHAHA. I tested this with "banana" as the location set to Melbourne but apparently, there is a town called banana in Australia. https://www.google.com/maps/place/Banana+QLD+4702/data=!4m2!3m1!1s0x6bc13d589f58a60f:0x400eef17f20ccc0?sa=X&ved=2ahUKEwiAlNXZs73tAhXH4zgGHQKRC4gQ8gEwG3oECCcQAQ 🍌 |
4 tasks
enjeyw
added a commit
that referenced
this pull request
Dec 15, 2020
* master: (28 commits) Adding blockchain_task_uuid index to worker messages (#551) Make location lookup look at existing users' coordinates as a last resort (#555) Add support for Commcare (#569) Improve external transaction detection (#570) Remove unused imports (#571) Celo integration (#535) feat: small improvements to accessibility across the web app (#562) Group by Sender and Recipient (#567) Enable multiple chains (#496) Silence loading spinner warning (#568) Custom attribute bugfix (#549) Antify Message Bar (#566) Stop retrying infinitely (#565) Only update BlockchainTransaction on the worker when we absolutely have to (#564) Make SynchronizedBlock be updated in batch instead of one giant update (#563) Hide Filters and Groups (#558) adding more colors to charts, and tweaking legends (#561) Chart Tweaks (#560) Recipients filter (#533) Dynamic transfer card loaded (#559) ... # Conflicts: # app/server/api/transfer_card_api.py # app/test_app/functional/api/test_transfer_card_api.py
enjeyw
added a commit
that referenced
this pull request
Jan 15, 2021
* master: (27 commits) Minimum withdrawal amount (#528) Remove refresh_user_locations from seed.py (#576) Search 2.0 (#581) Re-implements the XLSX/CSV uploader (#575) Fix to make sure custom attributes are included on export (#592) Bump cairosvg from 2.4.2 to 2.5.1 in /app (#590) Remove orjson requirement (#591) URL Builder for Kobo/Commcare Integrations (#578) Re-Enable Caching for Metrics (#532) Do the thing (#589) fix: mock data error (#582) style: improve view only functionality (#587) Fix null subtraction error (#586) Don't make index if it's already there (#584) Circle was being weird. This fixes it! (#588) Transfer Card Fetching Improvements (#580) Make map work again (#577) Stop requiring chains and default_chain in config files (#579) Adding blockchain_task_uuid index to worker messages (#551) Make location lookup look at existing users' coordinates as a last resort (#555) ... # Conflicts: # .circleci/config.yml # config.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the Pull Request
Make location lookup look at existing users' coordinates as a last resort. Also apply retroactively!
Todo