Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Accept other css units on MenuHeigth prop #53

Open
gsasouza opened this issue Aug 30, 2018 · 2 comments
Open

Feature Request: Accept other css units on MenuHeigth prop #53

gsasouza opened this issue Aug 30, 2018 · 2 comments

Comments

@gsasouza
Copy link

Will be good if we can define MenuHeigth in differents css units. vh and vw for example will improve menu resposivity.

@techniq
Copy link
Owner

techniq commented Aug 31, 2018

@gsasouza This might be difficult currently with the use of react-virtualized as it needs explicit pixel units, although I've considered dropping the use of react-virtualized in the next major version (and re-releasing the current version as mui-virtualized-downshift or similar).

I did this for mui-table 2.0.0, and released 1.0.0 as mui-virtualized-table and documented some of the benefits here (mostly specific to a table, but related). I'm going to going create a new issue to discuss this change (but no timeline when this might be available).

@techniq
Copy link
Owner

techniq commented Sep 5, 2018

@gsasouza See this comment that might give you a sufficient workaround until (and if) #54 is implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants