Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IE11 Text visible on screen #4

Closed
digitaljohn opened this issue Feb 24, 2020 · 1 comment
Closed

IE11 Text visible on screen #4

digitaljohn opened this issue Feb 24, 2020 · 1 comment

Comments

@digitaljohn
Copy link

It appears when used inside IE11 the text element you use for measuring text size remains visible on the page, e.g.

image

My temporary fix is just setting the style, e.g.

#__react_svg_text_measurement_id{
  opacity: 0;
}

This element should be removed after measurement is complete?

@techniq
Copy link
Owner

techniq commented Feb 25, 2020

Hi @digitaljohn, thanks for checking out the project. It is intentional to leave the element for performance reasons (adding/removing dom elements can get expensive).

A few years ago I migrated this project to vx as @vx/text (which I help maintain) and can be installed individually. It has had numerous improvements since moving there, including recent Typescript support. I just looked and we also render the element offscreen using absolute positions which should remedy your issue.

You're welcome to continue to use this project, but you'd probably be better off using @vx/text since all maintenance will be done there.

@techniq techniq closed this as completed Feb 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants