Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Svelte 5 support / migration #351

Open
techniq opened this issue May 16, 2024 · 3 comments
Open

Svelte 5 support / migration #351

techniq opened this issue May 16, 2024 · 3 comments

Comments

@techniq
Copy link
Owner

techniq commented May 16, 2024

Creating an overarching issue to track migrating to Svelte 5.

The plan is for Svelte UX 1.x to support Svelte 3, 4, and 5 by not leveraging Svelte 5 specific features like runes and snippets, and 2.x+ will leverage these Svelte 5 specific features.

See known compatibility issues (none unresolved at this time)

@MadsHL
Copy link

MadsHL commented Oct 17, 2024

I can see that project is created with svelte 4 even when svelte 5 is chosen:
"svelte": "next",
Svelte 5 package should look like:
"svelte": "^5.0.0-next.268",

Besides that, there is not full support:
SelectField.svelte gives for example:
node_invalid_placement_ssr: (node_modules/svelte-ux/dist/components/SelectField.svelte:289:0) cannot contain (node_modules/svelte-ux/dist/components/Button.svelte:421:0)

@techniq
Copy link
Owner Author

techniq commented Oct 17, 2024

Hi @MadsHL 👋, thanks for the feedback.

Regarding the svelte version, I assume you are using npm create svelte-ux@latest. If so, and you used the layerchart template, I recently fixed an issue with this template that should be resolved now.

With that said, next is what is expected, as the tag points to the latest Svelte 5 version, 5.0.0-next.269 as of now.

image


Regarding the SelectField regression, thanks for the report. I'm tracking all known regressions in issue #144, and have added this one. What's interesting is the current PR preview, which is based on an older Svelte 5 version ATM, works fine, but based on the error, it looks like it might be an SSR specific issue, and the docs currently have ssr disabled to work around an issue with AppLayout and js initialization.

Many of these regressions just need to be isolated into a minimal repo and reported upstream, but I haven't had time to investigate the issue yet. If you have time to identify the root cause of the implementation, I would love some assistance to find the root cause of the regression.

Have a great day!

@techniq
Copy link
Owner Author

techniq commented Oct 18, 2024

@MadsHL SelectField ssr issue fixed once I merge PR #436

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants