Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add typehint to class param passed to Reflector/invokeStaticMethod #1817

Merged

Conversation

ragnard
Copy link
Contributor

@ragnard ragnard commented Jan 29, 2015

Eliminates reflection warnings like:

Reflection warning, /tmp/form-init6919407174722938138.clj:1:991 - call to static method invokeStaticMethod on clojure.lang.Reflector can't be resolved

when using lein run and friends.

Eliminates reflection warnings like:

   Reflection warning, /tmp/form-init6919407174722938138.clj:1:991 -
   call to static method invokeStaticMethod on clojure.lang.Reflector
   can't be resolved

when using `lein run` and friends.
technomancy added a commit that referenced this pull request Jan 29, 2015
…method

Add typehint to `class` param passed to Reflector/invokeStaticMethod
@technomancy technomancy merged commit 3b61cac into technomancy:master Jan 29, 2015
@technomancy
Copy link
Owner

Looks good; thanks.

@ragnard ragnard deleted the typehint-reflector-invokestaticmethod branch January 29, 2015 13:49
@ragnard
Copy link
Contributor Author

ragnard commented Jan 29, 2015

Just a minor annoyance :-)

Thanks for merging, and thanks for your great work with leiningen!

@glts
Copy link
Collaborator

glts commented Sep 1, 2017

@technomancy I doubt this change ever had any effect.

Repro on master:

  • lein new app foo && cd foo
  • Add dev profile {:dev {:global-vars {*warn-on-reflection* true}}}
  • lein run
Reflection warning, /tmp/form-init5226456295428185192.clj:1:854 - call to static method invokeStaticMethod on clojure.lang.Reflector can't be resolved (argument types: unknown, java.lang.String, unknown).
Hello, World!

Unfortunately I don’t know how to typehint quoted things before evaling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants