Skip to content
This repository has been archived by the owner on May 11, 2021. It is now read-only.

Minor optimizations #39

Merged
merged 11 commits into from
Sep 18, 2018
Merged

Minor optimizations #39

merged 11 commits into from
Sep 18, 2018

Conversation

FrancesCoronel
Copy link
Member

Fixes #14 #23

  • Renames banner value to image
  • Formatting for COC
  • Contributing guidelines updated
  • Added images for sponsors, communities, and events

✅️ By submitting this PR, I have verified the following

Frances Coronel and others added 4 commits September 14, 2018 23:38
*Total -- 474.49kb -> 379.54kb (20.01%)

/src/img/logo-alt.png -- 123.57kb -> 92.92kb (24.81%)
/src/img/homepage.jpg -- 350.92kb -> 286.62kb (18.32%)
…roduction

Signed-off-by: Frances Coronel <hello@fvcproductions.com>

# Conflicts:
#	README.md
#	site/content/sponsors.md
Signed-off-by: Frances Coronel <hello@fvcproductions.com>
@FrancesCoronel FrancesCoronel added the enhancement New feature or request label Sep 15, 2018
@FrancesCoronel FrancesCoronel self-assigned this Sep 15, 2018
@FrancesCoronel FrancesCoronel added the review This issue is under review - used by Waffle.io tracker label Sep 15, 2018
@FrancesCoronel FrancesCoronel mentioned this pull request Sep 15, 2018
2 tasks
.src("./src/sass/styles.scss")
.pipe(
sass({
outputStyle: "compressed",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this comma needed here?

Copy link
Collaborator

@fvntr fvntr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks geat, have some minor comments

@@ -1,7 +1,9 @@
---
title: Communities 👥️
description: Our online communities provide a space to communicate with each other, post about job offers, ask for career advice, share events, music and even recipes!
description: Safe spaces to network and connect with other Latinx in tech.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think safe spaces here isnt needed

@@ -1,5 +1,6 @@
---
title: GitHub Organization
description: "Contribute to this website and much more!"
description: 'Contribute to this website and much more!'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no quotes, since the other desc have no quotes as well

@@ -1,5 +1,6 @@
---
title: Twitter - LA
description: "A community of #latinxintech in Los Angeles hosting local tech meetups and social gatherings/comidas. We’re here! Aquí estamos! #SiSePuede"
description: 'A community of #latinxintech in Los Angeles hosting local tech meetups and social gatherings/comidas. We’re here! Aquí estamos! #SiSePuede'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no quotes

site/layouts/partials/sponsor-us.html Show resolved Hide resolved
@dvidsilva dvidsilva merged commit d01578c into techqueria:master Sep 18, 2018
@dvidsilva dvidsilva removed the review This issue is under review - used by Waffle.io tracker label Sep 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants