Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename the field session_name to service_instance_name #64

Closed
vaibhav-kaushal opened this issue Oct 10, 2023 · 0 comments · Fixed by #93
Closed

Rename the field session_name to service_instance_name #64

vaibhav-kaushal opened this issue Oct 10, 2023 · 0 comments · Fixed by #93
Milestone

Comments

@vaibhav-kaushal
Copy link
Contributor

The field session_name in the database (and the corresponding struct fields in the code) actually refer to the instance of the service that sent the log message to the server. The current name session_name is ambiguous, especially when we are talking about user login session and similar stuff. We should rename it to something which makes more sense, e.g. service_instance_name would be a good choice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant