Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test AssignProcedure changes #60

Closed
brennanMosher opened this issue Mar 17, 2021 · 7 comments
Closed

Test AssignProcedure changes #60

brennanMosher opened this issue Mar 17, 2021 · 7 comments
Assignees

Comments

@brennanMosher
Copy link
Collaborator

Test the changes to file names in AssignProcedures

@brennanMosher brennanMosher self-assigned this Mar 17, 2021
@ted537
Copy link
Owner

ted537 commented Mar 22, 2021

I have pushed a test case to the assign branch. There are errors in the semantic output. Could you take a look?

@brennanMosher
Copy link
Collaborator Author

Yeah I'll take a look later tonight

@brennanMosher
Copy link
Collaborator Author

Fixed the issue. It was the test case. Assign accepts the file variable before the string name. I think I'm getting the right output now. I'll push to the branch and make a PR

@ted537
Copy link
Owner

ted537 commented Mar 23, 2021

That's not what the prof has said; I believe the test case was correct

https://onq.queensu.ca/d2l/le/447455/discussions/threads/4324421/View

@brennanMosher
Copy link
Collaborator Author

Based on this link: https://www.freepascal.org/docs-html/rtl/system/assign.html I believe the updated test is correct. It is also the way the code works. It checks first for an identifier of file type then checks the file name.

I'm not completely sure but I think he may have just been mistaken on that.

@ted537
Copy link
Owner

ted537 commented Mar 23, 2021

Could you make an onQ discussion for this? I reckon you guess is right but it doesn't hurt to confirm

@brennanMosher
Copy link
Collaborator Author

Yep I'll do that first thing in the morning. Might be a bit late but I'll try anyways

@brennanMosher brennanMosher mentioned this issue Mar 23, 2021
@ted537 ted537 closed this as completed Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants