Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BulkLoad do not validateParameters() #421

Open
Llorx opened this issue Aug 8, 2016 · 2 comments
Open

BulkLoad do not validateParameters() #421

Llorx opened this issue Aug 8, 2016 · 2 comments
Labels
known issue for any issue that has been reported or there's a PR with the fix

Comments

@Llorx
Copy link

Llorx commented Aug 8, 2016

Simple as that. If I add a 1234123 value to a SmallInt, I receive this error:

TypeError: value is out of bounds at checkInt (buffer.js:716:11) at Buffer.writeInt16LE (buffer.js:874:5) at WritableTrackingBuffer.writeInt16LE (lib\mssql\node_modules\tedious\lib\tracking-buffer\writable-tracking-buffer.js:165:19) at Object.writeParameterData (lib\mssql\node_modules\tedious\lib\data-type.js:108:23) at BulkLoad.addRow (lib\mssql\node_modules\tedious\lib\bulk-load.js:126:16) at lib\mssql\node_modules\mssql\lib\tedious.js:688:22 at Transaction.queue (lib\mssql\node_modules\mssql\lib\main.js:1010:9) at Request._acquire (lib\mssql\node_modules\mssql\lib\main.js:1178:33) at Request.TediousRequest.bulk (lib\mssql\node_modules\mssql\lib\tedious.js:609:21) at Request._bulk (lib\mssql\node_modules\mssql\lib\main.js:1457:53)

Following the source code, BulkLoad do not validate anything before calling AddRow.

@arthurschreiber
Copy link
Collaborator

#677 will fix this.

@Llorx
Copy link
Author

Llorx commented May 5, 2018

Can't close as we are not following the project were we used tedious so can't check if is fixed.

@IanChokS IanChokS added the known issue for any issue that has been reported or there's a PR with the fix label Dec 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
known issue for any issue that has been reported or there's a PR with the fix
Projects
None yet
Development

No branches or pull requests

3 participants