Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Returned data types... #44

Closed
tracker1 opened this issue Aug 3, 2012 · 3 comments
Closed

Returned data types... #44

tracker1 opened this issue Aug 3, 2012 · 3 comments

Comments

@tracker1
Copy link
Contributor

tracker1 commented Aug 3, 2012

With node-uuid, would it be possible to have the UNIQUEIDENTIFIER return the string representation?

Also, what about having binary strings return a Buffer?


On a side note... really like tedious, way more polished than node-sqlserver is at this point... what a headache.

@pekim
Copy link
Collaborator

pekim commented Aug 3, 2012

It's not clear to me whether SQL Server's UNIQUEIDENTIFIER is an RFC4122 v4 UUID. It is 128bits, so it could certainly be treated as one. It would be easy enough to use node-uuid's unparse function to turn the value in to a string. I think that it's a reasonable thing to do.

As for exposing varbinary and image as a Buffer instead of an array of integers, that makes perfect sense. I don't know what I was thinking when I originally coded it.

@tracker1
Copy link
Contributor Author

tracker1 commented Aug 6, 2012

It is v4 Compliant, but it's seeded with system info for part of its' randomness iirc...

@cortfritz
Copy link
Contributor

fwiw I submitted a helper that converts the array to the string representation as a pull-request in #52

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants