Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tmt process even disabled objects #2299

Open
sopos opened this issue Sep 1, 2023 · 3 comments
Open

tmt process even disabled objects #2299

sopos opened this issue Sep 1, 2023 · 3 comments

Comments

@sopos
Copy link

sopos commented Sep 1, 2023

The following plan should rather not find anything than failing on unhashable type: 'DependencyFmfId'

/test:
    enabled: false
    require:
      - name: /library
        type: library
        path: ../tests
    duration: 5m
    test: ./runtest.sh
/plan:
    discover:
      - how: fmf
    execute:
        how: tmt
$ tmt run discover
/var/tmp/tmt/run-049

/plan
    discover
        how: fmf
        directory: /home/dapospis/test/git/SP_components/a

plan failed

The exception was caused by 1 earlier exceptions

Cause number 1:

    unhashable type: 'DependencyFmfId'

I would expect tmt not to process disabled objects.

@happz
Copy link
Collaborator

happz commented Sep 1, 2023

Hm, leaving the enabled aside, using unhashable types like DependencyFmfId dataclass in set() is a nasty bug...

@happz
Copy link
Collaborator

happz commented Sep 1, 2023

Trying to fix the error message with #2300

@lukaszachy
Copy link
Collaborator

I'm afraid there is no way of not processing disabled objects as processing is the 'fmf' (file format) responsibility and disable/enable comes from tmt (metadata specification).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants