Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dogfooding tmt-lint pre-commit #2809

Open
LecrisUT opened this issue Apr 2, 2024 · 0 comments
Open

dogfooding tmt-lint pre-commit #2809

LecrisUT opened this issue Apr 2, 2024 · 0 comments

Comments

@LecrisUT
Copy link
Contributor

LecrisUT commented Apr 2, 2024

Right now the pre-commit for linting tmt-lint is linked to the last release, i.e.:

  - repo: https://github.com/teemtee/tmt.git
    rev: 1.31.0

Was considering using repo: local and duplicating the configuration in .pre-commit-hooks.yaml:

  - repo: local
    hooks:
    - id: tmt-lint
      name: tmt-lint
      entry: bash -c "git ls-files --error-unmatch $(python3 -c 'import tmt; print(tmt.Tree(logger=tmt.Logger.create(), path=\".\").root)')/.fmf/version && tmt lint --failed-only --source $@" PAD
      files: '.*\.fmf$'
      verbose: false
      pass_filenames: true
      language: python
      language_version: python3

This does not seem to work because it doesn't install the fmf dependencies properly (maybe also not the pip install .?). Anyone got ideas or references around it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant