Use beakerlib library from current repository / metadata tree

[ep69]

As a tester writing the test that needs beakerlib library from the same repository, I want to be able to use that library without specifying URL of the repository, so that the URL information is not duplicated and the whole repository is more maintainable & migratable.

From the discussion we had with @psss, the first step is to have url part of FMF id default to the same repository as the current test. Also, as brought up by @kkaarreell, new convention or specific agreement for rlImport arguments might be needed.

[kkaarreell]

We use rlImport ./ica for our library but this approach won't ensure that library requires are installed.
https://gitlab.cee.redhat.com/rhel-tests/openssl-ibmca/-/blob/main/integration/mod_ssl-using-ibmca-hw-acceleration/test.sh#L20

[lukaszachy]

FTR: Either 'url' or 'path' is currently required when processing requires.
We had defined 'fmf-id' that when url is missing it should be the current repo - thus omitting 'url' should lead to the desired "detect library from the current tree" situation.

[sopos]

I think it should work even with the file type require. That should ensure the respective file is synced to guest.
Beakerlib should be already capable to handle a require defined by the name only, possibly with path as well; so rlImport --all or a dependent requires should be handled correctly.

[psss]

As @sopos mentioned the library should be found using the upward directory traversal. @ep69, could you confirm this does not work for you?

[ep69]

What exact scenario are we discussing? rlImport fips / rlImport distribution/fips / rlImport crypto/fips + require: library(<same>) in main.fmf? What is expected to work and what not?

[sopos]

All should work if you have the following directory structure in the repo:
[/libs]/fips
[/libs]/distribution/fips
[/libs]/crypto/fips

Except for the require: library(...). which would make tmt to try to install it which would fail. For that you would need to use the new type: file require.

[ep69]

This is not a high priority as I am able to workaround it, but it does not seem to be working for my case.

I was mostly looking for a way to have same test script and metadata running in two environments:

1. in internal company network, downloading the library (e.g., distribution/fips) from default place where it is stored
2. in public environment, having the libraries pre-downloaded in /libs in current repo

Is something like this possible? If so, cool, I can get rid of my workarounds and rewrites. If not, I can go on with my life, too.

[ep69]

Btw, specifying library without url:, just with path:, somehow does not work for me:

require:
  - type: library
    path: /libs/distribution
    name: /fips

gives me:

# tmt run -avvv plans -n interop tests -f "tag:interop-gnutls" provision -h local execute -h tmt --interactive test -n /Interoperability/gnutls_TLSv1-2-with-OpenSSL
/var/tmp/tmt/run-010
Found 1 plan.

/plans/interop
summary: Upstream interoperability
    discover
        how: fmf
        order: 50
        directory: /root/interop
        hash: 3def3aa
        filter: tag: interop
    finish
    
    Prune '/plans/interop' plan workdir '/var/tmp/tmt/run-010/plans/interop'.
        summary: 0 tasks completed

plan failed

The exception was caused by 1 earlier exceptions

Cause number 1:

    unhashable type: 'DependencyFmfId'

# tmt --version
tmt version: 1.26.1 (514544b2)

[kkaarreell]

If the library Is in the same repo why adding it to requires?