TEIID-5404: translator-jpa: Improve Embedded mappings handling. #1088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents column collisions and query failures involving Embedded mappings by keeping track of the ManagedType traversal. Fragments of the path are joined by '_' to form the column name. They are joined by '.' and stored in nameInSource to be used in JPQL queries.
|
This also allows for an Enum property inside an embedded PK. I forgot to break that out into a separate commit, but can do so upon request. |
|
Looks good to me |
shawkins
pushed a commit
that referenced
this pull request
Jul 5, 2018
This prevents column collisions and query failures involving Embedded mappings by keeping track of the ManagedType traversal. Fragments of the path are joined by '_' to form the column name. They are joined by '.' and stored in nameInSource to be used in JPQL queries.
shawkins
pushed a commit
that referenced
this pull request
Jul 5, 2018
This prevents column collisions and query failures involving Embedded mappings by keeping track of the ManagedType traversal. Fragments of the path are joined by '_' to form the column name. They are joined by '.' and stored in nameInSource to be used in JPQL queries.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents column collisions and query failures involving Embedded
mappings by keeping track of the ManagedType traversal. Fragments of the
path are joined by '_' to form the column name. They are joined by '.'
and stored in nameInSource to be used in JPQL queries.