Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Long, multirow format for diff(found | required) #121

Closed
tribbloid opened this issue Nov 25, 2023 · 3 comments
Closed

Long, multirow format for diff(found | required) #121

tribbloid opened this issue Nov 25, 2023 · 3 comments

Comments

@tribbloid
Copy link
Collaborator

tribbloid commented Nov 25, 2023

In addition, I'd also like to change the short format for diff, which uses a Scala 3 keyword as the splitting character (|).

We should change it to a more prominent Unicode like

@tribbloid
Copy link
Collaborator Author

PR should be available soon, the new diff looks like this:

newSource1.scala:15: error: type mismatch;
  Test.F[
    found   : Test.a.type (with underlying type Test.A)
    ━━━━━━━━:
    required: a.type (with underlying type a.type) where val a: Test.A
              ――(defined at newSource1.scala:13:18)
    ――(left side reduced from)
      Test.AA
  ]
      wrongf(new A)(new F[AA])
                    ^

@tek this is not the final version, we can revise it in all 1.1.0-RCx, feel free to suggest a better visualization format!

@tribbloid
Copy link
Collaborator Author

@tek submitted. Should be part of 1.1.0-RC1

@tribbloid
Copy link
Collaborator Author

released, closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant